Cygwin build fix

--------------07fuKoywrofsnsEx0a0jXAxC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I've found and fixed a problem in lispbibl.d. I've attached an 
indicative diff of the C file.

System: Windows 10, a fresh Cygwin, and the latest GitLab clisp.

I followed the instructions in INSTALL.windows ("3. Binaries for the 
Cygwin environment"), for 64-bit binaries. Besides the prescribed 
configure options, I added --ignore-absence-of-libsigsegv.

Make fails to produce spvw.o because lispbibl.c does this near line 1900:
#define CR 13
and then #includes a file (unix.c) that ultimate #includes
/usr/include/w32api/winnt.h
which itself has a legitimate symbol (not macro) named CR that gets 
replaced by 13 resulting in a syntax error.

My fix is to move the whole #define block a few lines down to after the 
#include block. That prevents the #define macros from inadvertently 
capturing symbols from the included files.

----
I'm not an expert C programmer, but this technique of #including a file 
after #defining a macro seems wrong in general. It makes changing the 
included file impossibly hard as its author isn't free to use any new 
symbols without fearing that an includer like clisp will capture them. 
If clisp files followed a rule of never allowing #includes to follow 
#defines, but to only ever precede them, I think that would consistently 
prevent this particular sort of variable capture regardless of the depth 
of an include hierarchy. An alternative prevention would be if include 
file authors only created symbols with some namespace prefix, though 
that would make their code unreadable.


With best wishes,

Vibhu
--------------07fuKoywrofsnsEx0a0jXAxC
Content-Type: text/x-patch; charset=UTF-8; name="lispbibl.c.diff"
Content-Disposition: attachment; filename="lispbibl.c.diff"
Content-Transfer-Encoding: base64

LS0tIGxpc3BiaWJsLmMub3JpZwkyMDIyLTA5LTI0IDE4OjM5OjA4LjUyNDA1NjIwMCArMDAwMAor
KysgbGlzcGJpYmwuYwkyMDIyLTA5LTI0IDIwOjAwOjM5LjAzMDgyNjIwMCArMDAwMApAQCAtMTg5
NCwxMyArMTg5NCw2IEBACiAKIC8qICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMgT1MtcmVsYXRlZCBy
b3V0aW5lcyAgIyMjIyMjIyMjIyMjIyMjIyMjIyMgKi8KIAotLyogZ2VuZXJhbCBzdGFuZGFyZCBj
b25zdGFudHMgZm9yIGNvbnRyb2wgY2hhcnM6ICovCi0jZGVmaW5lIEJTICAgIDggIC8qICAjXEJh
Y2tzcGFjZSAgICAgQmFja3NwYWNlICovCi0jZGVmaW5lIFRBQiAgIDkgIC8qICAjXFRhYiAgICAg
ICAgICAgVGFidWxhdG9yICovCi0jZGVmaW5lIExGICAgMTAgIC8qICAjXExpbmVmZWVkICAgICAg
bGluZWZlZWQgKi8KLSNkZWZpbmUgQ1IgICAxMyAgLyogICNcUmV0dXJuICAgICAgICBjYXJyaWFn
ZSByZXR1cm4gKi8KLSNkZWZpbmUgUEcgICAxMiAgLyogICNcUGFnZSAgICAgICAgICBmb3JtIGZl
ZWQsIG5ldyBwYWdlICovCi0KIC8qIERlc2lyZWQgcmVhY3Rpb24gd2hlbiBhbiBJL08gb3BlcmF0
aW9uIGNhbm5vdCBiZSBjb21wbGV0ZWQgaW1tZWRpYXRlbHkuICovCiB0eXBlZGVmIGVudW0gewog
ICBwZXJzZXZfZnVsbCwgICAgICAvKiBDb250aW51ZSB0aGUgSS9PIG9wZXJhdGlvbiB1bnRpbCB0
aGUgd2hvbGUgYnVmZmVyIGlzCkBAIC0xOTI4LDYgKzE5MjEsMTMgQEAKICNlbmRpZgogCiAKKy8q
IGdlbmVyYWwgc3RhbmRhcmQgY29uc3RhbnRzIGZvciBjb250cm9sIGNoYXJzOiAqLworI2RlZmlu
ZSBCUyAgICA4ICAvKiAgI1xCYWNrc3BhY2UgICAgIEJhY2tzcGFjZSAqLworI2RlZmluZSBUQUIg
ICA5ICAvKiAgI1xUYWIgICAgICAgICAgIFRhYnVsYXRvciAqLworI2RlZmluZSBMRiAgIDEwICAv
KiAgI1xMaW5lZmVlZCAgICAgIGxpbmVmZWVkICovCisjZGVmaW5lIENSICAgMTMgIC8qICAjXFJl
dHVybiAgICAgICAgY2FycmlhZ2UgcmV0dXJuICovCisjZGVmaW5lIFBHICAgMTIgIC8qICAjXFBh
Z2UgICAgICAgICAgZm9ybSBmZWVkLCBuZXcgcGFnZSAqLworCiAKIAogCg==

--------------07fuKoywrofsnsEx0a0jXAxC
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--------------07fuKoywrofsnsEx0a0jXAxC
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
clisp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/clisp-devel

--------------07fuKoywrofsnsEx0a0jXAxC--