Re: minor change to cllib/base.lisp, changes to gnuplot.lisp

> * In message <[email protected]>
> * On the subject of "minor change to cllib/base.lisp, changes to gnuplot.lisp"
> * Sent on Wed, 04 Jun 2003 12:48:54 -0400
> * Honorable rif <[email protected]> writes:
>
> I'm new to this list, so I'm not sure what the right format for
> suggesting/making changes is.

cvs diff -u

> 1.  Small change to base.lisp.  I suggest changing
> 
> (defcustom *datadir* pathname
>   (mk-path (user-homedir-pathname) :directory '(:relative "data"))
> 
> to 
> 
> (defcustom *datadir* pathname
>   (truename (mk-path (user-homedir-pathname) :directory '(:relative "data"))))

this is bad because if the user does not have this directory, he will
not be able to load base.lisp.

it would probably be better to use SAFE-TRUENAME

(defun safe-truename (path)
  "Like TRUENAME, but handle non-existing files.
Note that the directory must exist."
  (make-pathname :name (pathname-name path) :type (pathname-type path)
                 :defaults (truename (make-pathname :name nil :type nil
                                                    :defaults path))))

whenever a pathname is passed to the OS.


> 2.  I have made some (small) improvements to gnuplot.lisp --- I have
>     exposed the logscale argument to gnuplot, and I've "improved" the
>     use of the grid option so that either x, y, or both can be gridded
>     separately.  I'd be happy to donate the changed file back if that
>     is wanted.  I'm also planning on implementing some "higher-level"
>     functions on top of this, for making bar plots and ROC curves;
>     I'll probably put those in a separate file, but I'm also happy to
>     donate those.

please send the patch.

-- 
Sam Steingold (http://www.podval.org/~sds) running RedHat9 GNU/Linux
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.palestine-central.com/links.html>
Don't use force -- get a bigger hammer.


-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.