Re: trivial defsystem bug

Thanks for the report.

I will fix it asap in CVS.

marco






On Jun 16, 2005, at 10:26 AM, Cyrus Harmon wrote:

>
> Two calls to warn in defsystem seem wrong to me. First, foreign is 
> misspelled as Foreing in one case but, more importantly, a ~S is in 
> the warn format string, but there is no argument. I've added 
> system-name to the warn calls. patch below.
>
> Thanks,
>
> Cyrus
>
> Index: defsystem.lisp
> ===================================================================
> RCS file: /cvsroot/clocc/clocc/src/defsystem-3.x/defsystem.lisp,v
> retrieving revision 1.95
> diff -u -r1.95 defsystem.lisp
> --- defsystem.lisp      15 Jun 2005 14:49:53 -0000      1.95
> +++ defsystem.lisp      16 Jun 2005 14:23:36 -0000
> @@ -2652,7 +2652,7 @@
>            ;; string. So if case matters in the filename, use strings, 
> not
>            ;; symbols, wherever the system is named.
>             (when (foreign-system-p system)
> -             (warn "Foreing system ~S cannot be reloaded by 
> MK:DEFSYSTEM.")
> +             (warn "Foreign system ~S cannot be reloaded by 
> MK:DEFSYSTEM." system-name)
>               (return-from find-system nil))
>            (let ((path (compute-system-path system-name 
> definition-pname)))
>              (when (and path
> @@ -2674,7 +2674,7 @@
>      (:load
>       (or (unless *reload-systems-from-disk* (get-system system-name))
>           (when (foreign-system-p (get-system system-name))
> -           (warn "Foreign system ~S cannot be reloaded by 
> MK:DEFSYSTEM.")
> +           (warn "Foreign system ~S cannot be reloaded by 
> MK:DEFSYSTEM." system-name)
>             (return-from find-system nil))
>          (or (find-system system-name :load-or-nil definition-pname)
>              (error "Can't find system named ~s." system-name))))))
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> clocc-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/clocc-devel
>
--
Marco Antoniotti					http://bioinformatics.nyu.edu
NYU Courant Bioinformatics Group		tel. +1 - 212 - 998 3488
715 Broadway 10th FL				fax. +1 - 212 - 998 3484
New York, NY, 10003, U.S.A.



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click