Re: [patch] Updated Patch for fault-join-target-slot and update-objects-joins

Hi,

> > What should happen if the target slot is not a join slot at all, but a
> regular
> > one? I am getting an error at this point in fault-join-target-slot:
> > 
> > 	 (tdbi (view-class-slot-db-info
> > 		(find ts (class-slots (find-class jc)) 
> > 		      :key #'slot-definition-name))) 
> > 	 (retrieval (gethash :retrieval tdbi)) ; tdbi is nil
> 
> What is it that you are trying to do? :target-slot is specifically for 
> many-to-many joins, and i can't see it making sense outside of them. it 
> would probably be trivial to simply return the sql-slot-value of the 
> :target-slot when it is not a join slot, but i can't see what value this 
> gains.

I can't remember now, but it probably does not matter; I figured out the
intention of :target-slot and :set from the code.

> FWIW, although the patch corrects 'can't find class' issue, f-j-t-s 
> still doesn't work for my purposes as it doesn't fill in the primary 
> keys [...]

I hit the same problem; in-memory join-class instances are pretty useless if
one wants to modify something. I noticed that your patch is not in 3.5.0, but I
am going to try it. Namely, I already tried similar variants. The result:
better, but very slow. Perhaps calling find-all on (list jc) is a little faster
than what I tried... Anyway, I wish I knew what find-all did when supplied with
more than one view-class (in combination with inner-join).

Thanks,
Alex

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com