Re: patch: don't store literal null pointers in saved images

Kevin Rosenberg <kevin-HJRc7zDS/[email protected]> Tue, 9 May 2006 07:58:27 -0600
Newsgroups gmane.lisp.clsql.devel
Message-ID <[email protected]>
James Bielman wrote:
> This patch changes these variables to be symbol macros instead, so a
> fresh null pointer is used each time.  There are some testsuite
> failures on OpenMCL, but these failed before this patch as well.  All
> non-skipped tests pass on SBCL/x86-64.

Hi, James. The point of the defvar's is to avoid creating a new null
every time clsql needs a pointer to null-void. Your patch is nice to
support openmcl's save-application feature, but do think there is an
alternative way to support openmcl's save-application without
recreating a pointer each time with define-symbol-macro?

If not, perhaps your patch can be modified to use define-symbol-macro
only on openmcl (and maybe sbcl with its save-lisp-and-die) with the
presumption that the advantages of supporting save-application
outweights the minor microoptimization of reusing an already created
pointer.

Last, it interesting to hear about the CLSQL testsuite failures on
openmcl. I haven't had an openmcl box for a while. But, openmcl did
use to pass all of the CLSQL test suite. It appears there has been
some regression, unfortunately.

Kevin