[Patch] Update view-database only if the transaction succeeded

"Saurabh Nanda" <[email protected]> Wed, 12 Sep 2007 11:25:39 +0530
Newsgroups gmane.lisp.clsql.devel
Message-ID <[email protected]>
------=_Part_10342_10522338.1189576539641
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Kevin,

I've modified the behaviour of update-records-from-instance and
with-transaction to not set the view-database slot in  all the new
objects inserted when inside a transaction until the transaction is
fully committed.

Earlier, even if a transaction failed, and the objects were not
actually inserted in the DB, the view-database slot was being set.
This was causing problems while trying to re-insert the records -
update-records-from-instance would try to update the records instead
of inserting.

(This is the first time I'm using git so please guide me about the
correct way of submitting patches.)

Saurabh.
-- 
http://nandz.blogspot.com
http://foodieforlife.blogspot.com

------=_Part_10342_10522338.1189576539641
Content-Type: text/plain; name="0001-transaction-oodml-patch.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-transaction-oodml-patch.txt"
X-Attachment-Id: f_f6hf2s04

RnJvbSBiYThjZmY1NTFjNDUyMGEyZWU0MDE1NmEwNGNlOGQzNzI4YTI1MGNiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYXVyYWJoIE5hbmRhIDxzYXVyYWJobmFuZGFAZ21haWwuY29t
PgpEYXRlOiBXZWQsIDEyIFNlcCAyMDA3IDExOjIxOjAzICswNTMwClN1YmplY3Q6IFtQQVRDSF0g
byBNb2RpZmllZCB0aGUgYmVoYXZpb3VyIG9mIHVwZGF0ZS1yZWNvcmRzLWZyb20taW5zdGFuY2Ug
YW5kIHdpdGgtdHJhbnNhY3Rpb24gdG8gbm90IHNldCB0aGUgdmlldy1kYXRhYmFzZSBzbG90IGlu
CmFsbCB0aGUgbmV3IG9iamVjdHMgaW5zZXJ0ZWQgd2hlbiBpbnNpZGUgYSB0cmFuc2FjdGlvbiB1
bmlsIHRoZSB0cmFuc2FjdGlvbiBpcyBjb21taXR0ZWQuIEVhcmxpZXIsIGV2ZW4gaWYgYQp0cmFu
c2FjdGlvbiBmYWlscywgYW5kIHRoZSBvYmplY3RzIGFyZSBub3QgYWN0dWFsbHkgaW5zZXJ0ZWQg
aW4gdGhlIERCLCB0aGUgdmlldy1kYXRhYmFzZSBzbG90IHdhcyBiZWluZyBzZXQuIFRoaXMKd2Fz
IGNhdXNpbmcgcHJvYmxlbXMgd2hpbGUgdHJ5aW5nIHRvIHJlLWluc2VydCB0aGUgcmVjb3JkcyAo
dXBkYXRlLXJlY29yZHMtZnJvbS1pbnN0YW5jZSB3b3VsZCB0cnkgdG8gdXBkYXRlIHRoZQpyZWNv
cmRzIGluc3RlYWQgb2YgaW5zZXJ0aW5nKS4KLS0tCiBzcWwvZGF0YWJhc2UubGlzcCAgICB8ICAg
IDIgKysKIHNxbC9vb2RtbC5saXNwICAgICAgIHwgICAgOCArKysrKysrLQogc3FsL3RyYW5zYWN0
aW9uLmxpc3AgfCAgICA4ICsrKysrKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo
KyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3FsL2RhdGFiYXNlLmxpc3AgYi9zcWwv
ZGF0YWJhc2UubGlzcAppbmRleCBjMDdjZjdiLi5hYjRkMzllIDEwMDY0NAotLS0gYS9zcWwvZGF0
YWJhc2UubGlzcAorKysgYi9zcWwvZGF0YWJhc2UubGlzcApAQCAtMzMyLDMgKzMzMiw1IEBAIGZy
b20gdGhlIGJvZHkuIE1BS0UtREVGQVVMVCBoYXMgYSBkZWZhdWx0IHZhbHVlIG9mIE5JTC4iCiAg
ICAgICAgKGxpc3QgLGRhdGFiYXNlKQogICAgICAsQGJvZHkpKQogCis7OzsKKyhkZWZ2YXIgKnRy
YW5zYWN0aW9uLWluc2VydC1saXN0KikKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYg
LS1naXQgYS9zcWwvb29kbWwubGlzcCBiL3NxbC9vb2RtbC5saXNwCmluZGV4IDAzZjAyODcuLjYz
NjkzODYgMTAwNjQ0Ci0tLSBhL3NxbC9vb2RtbC5saXNwCisrKyBiL3NxbC9vb2RtbC5saXNwCkBA
IC0yMzgsNyArMjM4LDEzIEBACiAJICAgICAgKGluc2VydC1yZWNvcmRzIDppbnRvIChzcWwtZXhw
cmVzc2lvbiA6dGFibGUgdmlldy1jbGFzcy10YWJsZSkKIAkJCSAgICAgIDphdi1wYWlycyByZWNv
cmQtdmFsdWVzCiAJCQkgICAgICA6ZGF0YWJhc2UgZGF0YWJhc2UpCi0JICAgICAgKHNldGYgKHNs
b3QtdmFsdWUgb2JqICd2aWV3LWRhdGFiYXNlKSBkYXRhYmFzZSkpKSkpKQorICAgICAgICAgIDs7
IHRoZSB2aWV3LWRhdGFiYXNlIHNob3VsZCBiZSBzZXQgb25seSBpZiB3ZSdyZSBub3QgaW4gYSB0
cmFuc2FjdGlvbgorICAgICAgICAgIDs7IGlmIHdlJ3JlIGluIGEgdHJhbnNhY3Rpb24gYW5kICp0
cmFuc2FjdGlvbi1pbnNlcnQtbGlzdCogaXMgYm91bmQKKyAgICAgICAgICA7OyBwdXNoIHRoaXMg
b2JqZWN0IGluIHRoYXQgbGlzdAorICAgICAgICAgIChpZiAoYW5kIChpbi10cmFuc2FjdGlvbi1w
IDpkYXRhYmFzZSBkYXRhYmFzZSkKKyAgICAgICAgICAgICAgICAgICAoYm91bmRwICcqdHJhbnNh
Y3Rpb24taW5zZXJ0LWxpc3QqKSkKKyAgICAgICAgICAgICAgKHB1c2ggb2JqICp0cmFuc2FjdGlv
bi1pbnNlcnQtbGlzdCopCisgICAgICAgICAgICAgIChzZXRmIChzbG90LXZhbHVlIG9iaiAndmll
dy1kYXRhYmFzZSkgZGF0YWJhc2UpKSkpKSkpCiAgICh2YWx1ZXMpKQogCiAoZGVmbWV0aG9kIGRl
bGV0ZS1pbnN0YW5jZS1yZWNvcmRzICgoaW5zdGFuY2Ugc3RhbmRhcmQtZGItb2JqZWN0KSkKZGlm
ZiAtLWdpdCBhL3NxbC90cmFuc2FjdGlvbi5saXNwIGIvc3FsL3RyYW5zYWN0aW9uLmxpc3AKaW5k
ZXggYjc2NzNkOC4uNDA4MmJmYyAxMDA2NDQKLS0tIGEvc3FsL3RyYW5zYWN0aW9uLmxpc3AKKysr
IGIvc3FsL3RyYW5zYWN0aW9uLmxpc3AKQEAgLTk3LDcgKzk3LDggQEAgd2hpY2ggaXMgKkRFRkFV
TFQtREFUQUJBU0UqIGJ5IGRlZmF1bHQsIGFuZCBleGVjdXRlcyBCT0RZIHdpdGhpbgogdGhhdCB0
cmFuc2FjdGlvbi4gSWYgQk9EWSBhYm9ydHMgb3IgdGhyb3dzLCBEQVRBQkFTRSBpcyByb2xsZWQK
IGJhY2sgYW5kIG90aGVyd2lzZSB0aGUgdHJhbnNhY3Rpb24gaXMgY29tbWl0dGVkLiIKICAgKGxl
dCAoKGRiIChnZW5zeW0gImRiLSIpKSkKLSAgICBgKGxldCAoKCxkYiAsZGF0YWJhc2UpKQorICAg
IGAobGV0ICgoLGRiICxkYXRhYmFzZSkKKyAgICAgICAgICAgKCp0cmFuc2FjdGlvbi1pbnNlcnQt
bGlzdCogbmlsKSkKICAgICAgICh1bndpbmQtcHJvdGVjdAogICAgICAgICAgICAocHJvZzIKICAg
ICAgICAgICAgICAoZGF0YWJhc2Utc3RhcnQtdHJhbnNhY3Rpb24gLGRiKQpAQCAtMTA1LDcgKzEw
NiwxMCBAQCBiYWNrIGFuZCBvdGhlcndpc2UgdGhlIHRyYW5zYWN0aW9uIGlzIGNvbW1pdHRlZC4i
CiAgICAgICAgICAgICAgICAsQGJvZHkpCiAgICAgICAgICAgICAgKG1hcmstdHJhbnNhY3Rpb24t
Y29tbWl0dGVkICxkYikpCiAgICAgICAgIChpZiAoZXEgKHRyYW5zYWN0aW9uLXN0YXR1cyAodHJh
bnNhY3Rpb24gLGRiKSkgOmNvbW1pdHRlZCkKLSAgICAgICAgICAgIChkYXRhYmFzZS1jb21taXQt
dHJhbnNhY3Rpb24gLGRiKQorICAgICAgICAgICAgKHByb2duCisgICAgICAgICAgICAgIChkYXRh
YmFzZS1jb21taXQtdHJhbnNhY3Rpb24gLGRiKQorICAgICAgICAgICAgICAoZG9saXN0IChvYmog
KnRyYW5zYWN0aW9uLWluc2VydC1saXN0KikKKyAgICAgICAgICAgICAgICAoc2V0ZiAoc2xvdC12
YWx1ZSBvYmogJ3ZpZXctZGF0YWJhc2UpICxkYikpKQogICAgICAgICAgICAgKGRhdGFiYXNlLWFi
b3J0LXRyYW5zYWN0aW9uICxkYikpKSkpKQogCiAoZGVmdW4gY29tbWl0ICgma2V5IChkYXRhYmFz
ZSAqZGVmYXVsdC1kYXRhYmFzZSopKQotLSAKMS40LjQuMgoK
------=_Part_10342_10522338.1189576539641
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
CLSQL-Devel mailing list
[email protected]
http://lists.b9.com/mailman/listinfo/clsql-devel

------=_Part_10342_10522338.1189576539641--