Re: RFC/patch: normalised object oriented clsql?
Thijs Oppermann <[email protected]>
| Newsgroups | gmane.lisp.clsql.general |
|---|---|
| Message-ID | <[email protected]> |
I just finished the first draft of adding documentation for normalised view-classes. I pushed the changes to my clsql-fork branch named 'normalised-inheritance', under commit 625970da6c9b22030b6944169d21c4a2e81880b8. Any comments are of course welcome. If I should attach a patch to the list, I could do that too... And as an aside, I also added a small bugfix for the case where the top-level parent primary key column does not use :auto-increment. Casual testing shows it to work for those cases now too. Also, this little bug alerted me to the very high probability of these changes not being compatible as they are now with other databases besides mysql. As I don't have any other available that will need to be taken up by others... Thijs On Tue, Nov 24, 2009 at 10:19 PM, Kevin Rosenberg <kevin-HJRc7zDS/[email protected]> wrote: > Great. The XML files for the documentation is in the doc/ directory. > If you submit a patch to the XML file (which is in DocBook format), then > I can take care of generating new HTML and PDF files. > > Even if you don't know DocBook, it will be rather simple to follow the existing > tag format for your additions. > > Kevin > > On Nov 23, 2009, at 10:28 AM, Thijs Oppermann wrote: > >> Sure, I'd be willing to add documentation. Where would I do that, >> though? Is it generated from somewhere? I must be looking in the wrong >> place... >> >> Thijs >> >> On Sun, Nov 22, 2009 at 12:28 AM, Kevin Rosenberg <kevin-HJRc7zDS/[email protected]> wrote: >>> Thijs Oppermann wrote: >>>> Anyway, if you're interested you could clone it ( git clone >>>> git://github.com/thijs/clsql-fork.git ) and play around. Run the test >>>> suite and you should see if the normalised inheritance code works. I >>>> only have mysql here, though, so if you use something else you might >>>> run into trouble... I'd like to know. >>> >>> This looks like a very interesting addition. I'm pleased to see that you >>> added test cases for the patch. Would you be willing to also update the >>> documentation to include this new functionality? I can run the test suite >>> on a few SQL platforms. If it everythings works, has test case, and is documented, >>> I'd like to include your contributions to the project. >>> >>> Thanks Thisj! >>> >>> Kevin >>> >> > >