Patch for the handling of symbols in clsql
Mackram Raydan <[email protected]> Sat, 12 Apr 2014 13:51:37 +0300
| Newsgroups | gmane.lisp.clsql.general |
|---|---|
| Message-ID | <[email protected]> |
Hey everyone, Based on a previous thread, I have submitted a pull request to handle the output of symbols when saved with clsql. In line with the discussion with Russ, the functionality I submitted continues to use intern but makes checks on whether there are packages or not in the saved symbol and acts accordingly. One thing I have missed is writing test cases because I was not sure how best to proceed (although I have done tests on my end to verify everything is in order). The current tests call directly the high level functions such as select or update and not the lower functions like read-sql-value. I was not sure if I should change some of the def-view-classes to add a symbol column, or to add a new def-view-class for this specific test or to basically put the tests that I did directly on read-sql-value. Any suggestions on what you would like me to do? Finally I did the pull request to the git repository found at github.com even though the change is small (I am just used to pull requests), if someone prefers another method I have no problem in resubmitting in a different way. Thank you Mackram Raydan