Re: Patch for the handling of symbols in clsql

Howdy Macram Raydan,

Thanks for your efforts on our behalf.  I am sorry if my guidance led 
you astray or caused us to move the wrong direction (as it seems we 
actually should be using read-from-string for this case of reading 
readably-printed symbols).

For testing, I am fine with adding tests to every layer of the 
application from directly testing read-sql-value up to and including a 
symbol column on one of the datasets.  Obviously there can be too many 
tests, but testing that our assumptions work up and down the call stack 
doesn't seem bad to me.

Pull requests to that repository are fine, for me, to pull them in and 
merge and probably exportable for everyone else, so this is probably 
acceptable especially for "in-progress" work.  The official repo however 
is: http://git.b9.com/clsql.git/ if you were trying to reach Kevin directly.

Cheers,
Russ Tyndall
Acceleration.net

On 04/12/2014 06:51 AM, Mackram Raydan wrote:
> Hey everyone,
>
> Based on a previous thread, I have submitted a pull request to handle
> the output of symbols when saved with clsql. In line with the discussion
> with Russ, the functionality I submitted continues to use intern but
> makes checks on whether there are packages or not in the saved symbol
> and acts accordingly.
>
> One thing I have missed is writing test cases because I was not sure how
> best to proceed (although I have done tests on my end to verify
> everything is in order). The current tests call directly the high level
> functions such as select or update and not the lower functions like
> read-sql-value. I was not sure if I should change some of the
> def-view-classes to add a symbol column, or to add a new def-view-class
> for this specific test or to basically put the tests that I did directly
> on read-sql-value. Any suggestions on what you would like me to do?
>
> Finally I did the pull request to the git repository found at github.com
> even though the change is small (I am just used to pull requests), if
> someone prefers another method I have no problem in resubmitting in a
> different way.
>
> Thank you
>
> Mackram Raydan
> _______________________________________________
> CLSQL mailing list
> [email protected]
> http://lists.b9.com/cgi-bin/mailman/listinfo/clsql