Re: compile-file return values?
Douglas Crosher <[email protected]>
| Newsgroups | gmane.lisp.cmucl.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Ray, Thank you for the change. When this is out I'll look at updating the ASDF test. On 27/03/11 08:21, Raymond Toy wrote: >>>>>> "Douglas" == Douglas Crosher<[email protected]> writes: > > Douglas> I propose using the c::brevity extension to suppress the > Douglas> efficiency notes and then check the second value returned > Douglas> by compile-file. For example: > > Douglas> (proclaim '(optimize (speed 2) (safety 3) #-allegro > Douglas> (debug 3) > Douglas> #+(or scl cmu) (c::brevity 2))) > > This seems ok, but why these particular compiler settings used? These > aren't the default for cmucl. These setting are from the ASDF test, with the c::brevity added to avoid compiler efficiency notes (which are style-warnings in CMUCL) from causing the test to fail. I understand the test would like to catch many style-warnings, such as unused variables, and that the test should fail if these are found. > > Douglas> However this does not work on the current cmucl because > Douglas> the second value returned does not include > Douglas> style-warnings, so unused variable warnings etc are not > Douglas> caught in this test. > > Douglas> The ANSI-CL standard suggests that the second return > Douglas> value should be true for style-warnings, as well as other > Douglas> warnings and errors, so the original cmucl code seems > Douglas> right to me. > > Douglas> Perhaps there was some other issue here. > > I agree with your analysis; style warnings are counted as warnings. > > I'll make the suggested change soon. I vaguely remember some issues > with this long ago, and I thought they show up in the ansi-tests, but > I tested the snapshot version with a version with your suggested > change and there's no difference. I don't know what the issue can be > anymore. > > Ray > > _______________________________________________ > cmucl-imp mailing list > [email protected] > http://lists.zs64.net/mailman/listinfo/cmucl-imp > _______________________________________________ cmucl-imp mailing list [email protected] http://lists.zs64.net/mailman/listinfo/cmucl-imp