RE: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-related functions.

Maxime Devos <[email protected]>
Newsgroups gmane.lisp.guile.devel
Message-ID <[email protected]>
>Here are the "back to the track" reply for folks in this thread.
>
>So the situation is more clear now. The newline in various OS need to respectively tested. And my idea is to check OS via (uname) in test cases.
>Now that it's in tests, I think we don't have to talk much about the efficiency issue for this specific case.

No. See what I wrote previously about the subject, and note that most of it is independent of whether it’s for testing or not. As you previously said you intentionally did not read (parts of) the messages, I’m not going to repeat it for you.

In addition: why not simply _read_ the implementation of (ice-9 rdelim) to see what platform-detecting mechanism it uses (if any) and reuse that, instead of reinventing the wheel? Sounds like it would save effort and time, which you seem particularly interested in, and claimed effort/time is one of your own arguments against generalisation.

Also, it doesn’t need to be tested, since read-line is not what’s being added or modified here. (Tests for that may be good, but that’s off-topic, which you are rather against, and is your most coherent argument against generalisation.) Rather, either the used newline in the test needs to be adjusted per-platform, or the documentation of read-line needs to be adjusted to that \n is always a newline.

Also, it’s also not a proper “back to the track” reply, since it ignores the ‘generalisation’ component of the track.

Regards,
Maxime Devos
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.