Re: [PATCH] Fix broken handling of non-ASCII strings
Mark H Weaver <[email protected]> Thu, 23 Jun 2011 14:21:22 -0400
| Newsgroups | gmane.lisp.guile.gtk |
|---|---|
| Message-ID | <[email protected]> |
David Pirotte <[email protected]> writes: > I kind of remember, at some point in the discussion related to this > mater and you 'welcome as a guile-gnome' developer/maintainer that you > would apply these important patches to the main tree. Thanks for the reminder. Unfortunately my patch breaks compatibility with Guile 1.8, which does not provide a function to convert strings to UTF-8. We'll need to add an autoconf check for scm_to_utf8_stringn, and add a compatibility shim if it's not available. There's nothing very difficult here, but a few issues have conspired to cause procrastination on my part: * I've never hacked autoconf, so I'll need to educate myself. * I've never worked with Guile 1.8, and testing the new patch will require me to build gnome-guile against Guile 1.8, to make sure it doesn't break anything. * I'm uncomfortable with guile-gnome's weird "modules as branches" repository structure, especially given that this patch changes multiple modules. I must have confidence in my understanding of how this works before pushing the changes. Mark