Re: guile.m4

Aaron VanDevender <[email protected]> writes:

> Here is a slightly improved version of my guile.m4 patch. It has some
> more explicit comments and uses the guile executable set by GUILE_PROGS

Thanks for working on this.  I have a couple of queries.

> +GUILE_CHECK([GUILE_CORRECT_VERSION_P],
> +    [(exit (let loop ((v1 (map string->number (string-split (version) (string-ref \".\" 0))))
> +             (v2 (map string->number (string-split \"$1\" (string-ref \".\" 0)))))

Can we use #\. instead of (string-ref "." 0), or is the former a
nightmare to quote correctly?

> +             (cond ((and (null? v1) (null? v2)) 0)
> +                   ((null? v1) 0)
> +                   ((null? v2) 1)
> +                   ((> (car v1) (car v2)) 0)
> +                   ((< (car v1) (car v2)) 1)

Shouldn't the (null? v1) case have the same polarity as the (< v1 v2)
case (because absence == 0) ?

Regards,
     Neil



_______________________________________________
Guile-user mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/guile-user