Re: automatic build & test on pull requests

"R. Matthew Emerson" <[email protected]> writes:

> I recently added a GitHub workflow named =E2=80=9CBuild and test=E2=80=9D=
 in the
> https://github.com/Clozure/ccl repository.
>
> This is supposed to run automatically on pull requests. I=E2=80=99m start=
ing
> out with Linux only, since it=E2=80=99s the fastest and cheapest GitHub r=
unner
> platform.
>
> I=E2=80=99m not an expert on GitHub Actions, so I=E2=80=99d be happy to l=
earn about
> doing things better, or to get help from someone who is good at this
> stuff.
>
> The workflow file is
> https://github.com/Clozure/ccl/blob/master/.github/workflows/build-linux.=
yml

This seems quite reasonable to me. You may want to use a fixed version
number for the binaries you download and use to avoid surprises in the
future if "latest" changes. Also when using Curl in scripts, -sSfL is
usually what you want (be silent but still report errors, return a
non-zero exit code on failure, follow redirections).

Best,


--=20
Nicolas Martyanoff
https://n16f.net
[email protected]