Re: Hyphen in bigloo modules with Java backend?

 Hello, Manuel,
I have created a pull request. 

Thanks,Joe

    On Friday, March 19, 2021, 7:06:11 AM PDT, [email protected] <[email protected]> wrote:  
 
 Hi Joe,

>  Hello, 
> 
> I spent some time this weekend looking at possible solutions for the invalid class name issues we have been seeing. I have a branch that attempts to address the problem. It can be found at https://github.com/donaldsonjw/bigloo-1/tree/class_file_name_fixes.  It makes 3 minor changes to the bigloo compiler and the jfile tool.
> 1. jfile was modified to produce mangled qualified types when the
>    source file name contains identifiers not supported by the
>    JLS. Note, we are currently only doing the mangling for the base
>    name sans extension and not all directory components.
> 
> 2. The jvm backend was modified to honor the qualified type names
>    provided by jfile. Before this, the resulting class file was always
>    the base name of the source file with a .class extension.
> 
> 3. When no jfile information is provided, we mangle the auto-produced
>    qualified name, if needed.
> 
> The changes above provide the following behavior. Assuming a source
> file name test-case.scm containing a module named test-name with a
> -pbase of bigloo.test, jfile will produces the .jfile below
> 
> ((test-case "bigloo.test.BgL_testzd2casezd2"))
> 
> and the class file will be bigloo/test/BgL_testzd2casezd2.class.
> 
> For the same example src file when no .jfile is provided, the jvm backend will generate
> a class file named BgL_testzd2casezd2.class
> If people get a chance, let me know how this works for them.
> Thank You,Joseph Donaldson
Sorry again for my slow reaction.

Do you think you could create a new pull request on github? I will
accept it. Otherwise I could merge your branch manually but if possible
I would prefer to use github pull requests.

Thanks in advance.

-- 
Manuel