SAFE_MINUS JVM Fix
Joseph Donaldson <[email protected]> Wed, 23 Nov 2022 18:06:29 +0000 (UTC)
| Newsgroups | gmane.lisp.scheme.bigloo |
|---|---|
| Message-ID | <[email protected]> |
------=_Part_4105493_485058215.1669226789562 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, Manuel, I recently noticed that for the jvm backend simple subtraction expressions = such as (- -7 -8) were being promoted to bignum. Digging a bit deeper, I fo= und that the bignum promotion logic for SAFE_MINUS_* methods in foreign.jav= a were incorrect and not aligned with what was being used for the c/native = backend. I changed foreign.java to correct this and have created a=C2=A0 pu= ll request. Thanks,Joe=20 ------=_Part_4105493_485058215.1669226789562 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <html><head></head><body><div class="yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div dir="ltr" data-setdir="false">Hello, Manuel,</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">I recently noticed that for the jvm backend simple subtraction expressions such as (- -7 -8) were being promoted to bignum. Digging a bit deeper, I found that the bignum promotion logic for SAFE_MINUS_* methods in foreign.java were incorrect and not aligned with what was being used for the c/native backend. I changed foreign.java to correct this and have created a <a href="https://github.com/manuel-serrano/bigloo/pull/85" class="">pull request</a>.</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data- setdir="false"><br></div><div dir="ltr" data-setdir="false">Thanks,</div><div dir="ltr" data-setdir="false">Joe <br></div><div><br></div><div><br></div><div><br></div></div></body></html> ------=_Part_4105493_485058215.1669226789562--