Re: New egg: schematra
siiky via Chicken-users <[email protected]>
| Newsgroups | gmane.lisp.scheme.chicken |
|---|---|
| Message-ID | <[email protected]> |
Hey, This looks pretty good! One small thing to fix: the HTTP verbs[0] are macros, not procedures, so they should be tagged with `<syntax></syntax>` instead[1] in the wiki. One question: will the path argument of HTTP verbs always be a single element (`(path)`)? and if so, there's a reason for the extra parens? (other than easier backwards compatible extensibility) One suggestion for future versions: using alists for `(current-params)` may be fine, but don't force users to know that it's an alist, especially to use different comparator procedures (`equal?`/`eq?`) to access one or the other -- it's a bit ugly. :P (and hard to change in a backwards compatible way, but who care about that amirite?) Given the rest of the API I'm sure you can find a really good API for this as well! [0] https://wiki.call-cc.org/eggref/5/schematra#route-definition [1] https://wiki.call-cc.org/edit-help#tags-for-other-definitions [2] https://github.com/schematra/schematra/blob/94888a9787a55324c85412925c3f424ba3c39e06/schematra.scm#L241 Thanks for the egg, siiky