Re: master: Persist the :ucrt feature, if present, into the final image
Stas Boukarev <[email protected]>
| Newsgroups | gmane.lisp.steel-bank.cvs,gmane.lisp.steel-bank.devel |
|---|---|
| Message-ID | <CAF63=11R2-BJsiDmQC1w5yhcep5GJ8NvMea1+r4j2quWsNvLTg@mail.gmail.com> |
Aren't contribs built with sb-impl:+internal-features+ appended to *features*? Why is this change really needed? On Fri, Apr 24, 2026 at 2:13 PM crhodes via Sbcl-commits <[email protected]> wrote: > > The branch "master" has been updated in SBCL: > via 4dde13a7c1364ad9a3f39f023a069e689ef2e421 (commit) > from 8a98e7b59d99d353b84d0ecd0a1fb42a578103ae (commit) > > - Log ----------------------------------------------------------------- > commit 4dde13a7c1364ad9a3f39f023a069e689ef2e421 > Author: Christophe Rhodes <[email protected]> > Date: Fri Apr 24 12:10:42 2026 +0100 > > Persist the :ucrt feature, if present, into the final image > > It's probably not useful for users, but it is necessary for making the > right choice while building our own contribs. Acting on a report by > Masatoshi SANO. > --- > make-target-2-load.lisp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/make-target-2-load.lisp b/make-target-2-load.lisp > index 36c4de3dc..800eb4722 100644 > --- a/make-target-2-load.lisp > +++ b/make-target-2-load.lisp > @@ -74,7 +74,7 @@ > :64-BIT ; choice of word size. 32-bit if absent > :BIG-ENDIAN :LITTLE-ENDIAN ; endianness: pick one and only one > :BSD :UNIX :LINUX :WIN32 :DARWIN :SUNOS :ANDROID ; OS: pick one or more > - :FREEBSD :GNU-KFREEBSD :OPENBSD :NETBSD :DRAGONFLY :HAIKU > + :FREEBSD :GNU-KFREEBSD :OPENBSD :NETBSD :DRAGONFLY :HAIKU :UCRT > :MACH-O :ELF ; obj file format: pick zero or one > ;; I would argue that this should not be exposed, > ;; but I would also anticipate blowback from removing it. > > ----------------------------------------------------------------------- > > > hooks/post-receive > -- > SBCL > > > _______________________________________________ > Sbcl-commits mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/sbcl-commits _______________________________________________ Sbcl-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sbcl-commits