master: Remove questionable profiling result

snuglas via Sbcl-commits <[email protected]> Sat, 01 Aug 2026 20:50:00 +0000
Newsgroups gmane.lisp.steel-bank.cvs
Message-ID <[email protected]>
The branch "master" has been updated in SBCL:
       via  1a8c99523f5a3ca874ccbf1923d686fe5ff3db4d (commit)
      from  d28fd45be76a37fdb0106527aae61b5592f271b5 (commit)

- Log -----------------------------------------------------------------
commit 1a8c99523f5a3ca874ccbf1923d686fe5ff3db4d
Author: Douglas Katzman <[email protected]>
Date:   Sat Aug 1 16:37:38 2026 -0400

    Remove questionable profiling result
    
    A profile from linux perf shows CONSET-ADJOIN at about 1.25% of total time.
    I'm not sure how sb-sprof could be so wrong, though to be fair, the
    profile in the comment was taken a month ago, before many changes.
---
 src/compiler/constraint.lisp | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/src/compiler/constraint.lisp b/src/compiler/constraint.lisp
index fde14b0e6..240a65202 100644
--- a/src/compiler/constraint.lisp
+++ b/src/compiler/constraint.lisp
@@ -167,22 +167,6 @@
   (defun conset-difference (conset1 conset2)
     (sset-difference conset1 conset2) (values)))
 
-;;; Consets are still some of the worst-performing things in the compiler.
-;;; Profiling a particularly slow-compiling file shows the top 10 functions below:
-;;;            Self        Total        Cumul
-;;;   Nr  Count     %  Count     %  Count     %    Calls  Function
-;;; ------------------------------------------------------------------------
-;;;    1    985  20.7    985  20.7    985  20.7        -  SB-C::CONSET-ADJOIN
-;;;    2    939  19.7    939  19.7   1924  40.4        -  SB-KERNEL:%ADJOIN-EQ
-;;;    3    621  13.0    621  13.0   2545  53.5        -  SB-IMPL::GETHASH/EQ-HASH/COMMON
-;;;    4    476  10.0   1112  23.4   3021  63.5        -  SB-C::FIND-CONSTRAINT
-;;;    5    231   4.9   2465  51.8   3252  68.3        -  (FLET SB-C::BODY-FUN :IN SB-C::INHERIT-CONSTRAINTS)
-;;;    6    189   4.0   1570  33.0   3441  72.3        -  SB-C::JOIN-TYPE-CONSTRAINTS
-;;;    7    177   3.7    403   8.5   3618  76.0        -  SB-C::TYPE-FROM-CONSTRAINTS
-;;;    8    173   3.6   1278  26.8   3791  79.6        -  SB-C::FIND-OR-CREATE-CONSTRAINT
-;;;    9     66   1.4    210   4.4   3857  81.0        -  (FLET SB-C::BODY-FUN :IN SB-C::TYPE-FROM-CONSTRAINTS)
-;;;   10     58   1.2    123   2.6   3915  82.2        -  SB-KERNEL::%TYPE-INTERSECTION
-
 #+bitmapped-conset
 (locally
     ;; This is performance critical for the compiler, and benefits

-----------------------------------------------------------------------


hooks/post-receive
-- 
SBCL