Re: master: Remove without-gcing from coverage test

And it fails with:
::: UNEXPECTED-FAILURE :SB-COVER due to SIMPLE-ERROR:
        "The assertion (> (LENGTH *NEW-CODE*) 100) failed with
         (LENGTH *NEW-CODE*) = 52."

On Thu, Dec 4, 2025 at 8:54 PM snuglas via Sbcl-commits
<[email protected]> wrote:
>
> The branch "master" has been updated in SBCL:
>        via  8204ea01c5f1028c9ed71572ad30ea840fc5343a (commit)
>       from  3ba73edc495ab0f5d5726f46c4a5c3e8e0fb0886 (commit)
>
> - Log -----------------------------------------------------------------
> commit 8204ea01c5f1028c9ed71572ad30ea840fc5343a
> Author: Douglas Katzman <[email protected]>
> Date:   Thu Dec 4 12:49:01 2025 -0500
>
>     Remove without-gcing from coverage test
> ---
>  tests/sb-cover.impure.lisp | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/tests/sb-cover.impure.lisp b/tests/sb-cover.impure.lisp
> index ae05d51ee..d4470181f 100644
> --- a/tests/sb-cover.impure.lisp
> +++ b/tests/sb-cover.impure.lisp
> @@ -38,12 +38,18 @@
>      (warning (condition)
>        (error "Unexpected warning: ~A" condition))))
>
> +(defglobal *new-code* nil)
> +(defun preserve-code (underlying-fun object reason)
> +  (declare (ignore underlying-fun reason))
> +  (push object *new-code*)
> +  object)
> +(compile 'preserve-code)
> +;; Weak pointers to toplevel forms need to survive the entire test run
> +(sb-int:encapsulate 'sb-fasl::possibly-log-new-code 'override #'preserve-code)
> +
>  (with-test (:name :sb-cover)
>    (test-util:with-test-directory (sb-cover-test:*output-directory*)
> -    ;; Weak pointers to toplevel forms need to survive the entire test run
> -    (sb-sys:without-gcing
> -      (load (merge-pathnames "tests.lisp" sb-cover-test:*source-directory*)))
> -    (sb-sys:without-gcing
> -      (load (merge-pathnames "file-info-tests.lisp" sb-cover-test:*source-directory*)))
> -    (sb-sys:without-gcing
> -      (load (merge-pathnames "save-restore-tests.lisp" sb-cover-test:*source-directory*)))))
> +      (load (merge-pathnames "tests.lisp" sb-cover-test:*source-directory*))
> +      (load (merge-pathnames "file-info-tests.lisp" sb-cover-test:*source-directory*))
> +      (load (merge-pathnames "save-restore-tests.lisp" sb-cover-test:*source-directory*)))
> +  (assert (> (length *new-code*) 100)))
>
> -----------------------------------------------------------------------
>
>
> hooks/post-receive
> --
> SBCL
>
>
> _______________________________________________
> Sbcl-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sbcl-commits


_______________________________________________
Sbcl-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sbcl-commits