How to send patches?

Carl Gay <[email protected]>
Newsgroups gmane.lisp.steel-bank.devel
Message-ID <CALekcH2iT-t1XyYccg42oug-9Q6DL2_CaeBn026-9_O=P1xNbw@mail.gmail.com>
I've been reading through the Manual and fixing minor bugs (typos, grammar,
broken URLs and so on).  Before I make more changes I'd like to figure out
how to contribute them back to the project. sbcl/HACKING isn't extremely
specific about how that should be done so I'm hoping for some guidance.

Should I run git format-patch master..my-branch and attach all the patch
files it generates to an email?  For the size of commits I'm making this
will result in a lot of patch files so are larger commits (fewer
patch files) preferred?  (I guess I'm basically asking whether a human is
doing this manually or if you have a script that automates it for you.) Are
there any specific flags to format-patch that should be used?  Any other
advice?

(I've been using the GitHub mirror, which seems pretty up-to-date, but will
switch over to the SourceForge repo.)

I'm attaching the minor changes I've made. Please let me know if the
format's ok.

-Carl

_______________________________________________
Sbcl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sbcl-devel
0002-Minor-updates-to-README.patch (application/octet-stream, 1.2 KB)
From da89e7c39bfa2b0f51bdc50b3f40ea5bc8af1cec Mon Sep 17 00:00:00 2001
From: Carl Gay <[email protected]>
Date: Mon, 2 Feb 2026 23:43:52 -0500
Subject: [PATCH 2/3] Minor updates to README

* The BUGS file doesn't list bugs anymore.
* Add a URL where to subscribe to mailing lists.
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README b/README
index ef4271a07..e4f14c2df 100644
--- a/README
+++ b/README
@@ -18,14 +18,14 @@ source distribution; HTML version is available for download, and
 The system is a work in progress. See the "TODO" file in the source
 distribution for some highlights.
 
-The "BUGS" file lists current known bugs.
+See the "BUGS" file for how to view or report bugs.
 
 If you'd like to make suggestions, report a bug, or help to improve the
 system, please send mail to one of the mailing lists:
   [email protected]
   [email protected]
 Note that as a spam reduction measure you must subscribe to the lists
-before you can post.
+before you can post: https://sourceforge.net/p/sbcl/mailman/
 
 The "HACKING" file has more details regarding hacking on and
 contributing to SBCL.
-- 
2.39.3 (Apple Git-145)
0001-Fix-find-symbol-docstring-to-match-parameter-name.patch (application/octet-stream, 969 B)
From f2dc6564a6e3f3a49a481d232fb5c0ae81aade70 Mon Sep 17 00:00:00 2001
From: Carl Gay <[email protected]>
Date: Mon, 2 Feb 2026 21:56:59 -0500
Subject: [PATCH 1/3] Fix find-symbol docstring to match parameter name

---
 src/code/target-package.lisp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/code/target-package.lisp b/src/code/target-package.lisp
index c7b6c092c..221c9c55c 100644
--- a/src/code/target-package.lisp
+++ b/src/code/target-package.lisp
@@ -1460,7 +1460,7 @@ Experimental: interface subject to change."
                  nil))
 
   (defun find-symbol (name &optional (package (sane-package)))
-  "Return the symbol named STRING in PACKAGE. If such a symbol is found
+  "Return the symbol named NAME in PACKAGE. If such a symbol is found
   then the second value is :INTERNAL, :EXTERNAL or :INHERITED to indicate
   how the symbol is accessible. If no symbol is found then both values
   are NIL."
-- 
2.39.3 (Apple Git-145)
0003-Fix-URLs-in-the-Manual-Introduction.patch (application/octet-stream, 5.3 KB)
From 9ffb899cb2ca2f7a047381c0985cd7882723e791 Mon Sep 17 00:00:00 2001
From: Carl Gay <[email protected]>
Date: Tue, 3 Feb 2026 00:11:45 -0500
Subject: [PATCH 3/3] Fix URLs in the Manual "Introduction"

Some broken links but mostly using the URL that was the target of a redirect.
---
 doc/manual/intro.texinfo | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/doc/manual/intro.texinfo b/doc/manual/intro.texinfo
index e0f4c4f83..7fc59c7ec 100644
--- a/doc/manual/intro.texinfo
+++ b/doc/manual/intro.texinfo
@@ -346,7 +346,7 @@ Mode for Emacs) together with Emacs is recommended for use with
 SBCL, though other options exist as well.
 
 SLIME can be downloaded from
-@uref{http://www.common-lisp.net/project/slime/}.
+@uref{https://slime.common-lisp.dev/}.
 
 @node Language Reference
 @comment  node-name,  next,  previous,  up
@@ -356,7 +356,7 @@ SLIME can be downloaded from
 standard, made freely available by @emph{LispWorks} -- an invaluable
 reference.
 
-See: @uref{http://www.lispworks.com/reference/HyperSpec/index.html}
+See: @uref{https://www.lispworks.com/documentation/HyperSpec/Front/index.htm}
 
 @node Generating Executables
 @comment  node-name,  next,  previous,  up
@@ -439,14 +439,18 @@ Summarizes changes between various SBCL versions.
 If you're interested in the development of the SBCL system itself,
 then subscribing to @cite{sbcl-devel} is a good idea.
 
+@c FIXME: Copy historical info from the Web Archive to ... somewhere?
+
 SBCL internals documentation -- besides comments in the source -- is
-currently maintained as a @emph{wiki-like} website:
-@uref{http://sbcl-internals.cliki.net/}.
+available
+@uref{https://web.archive.org/web/20120814000933/http://sbcl-internals.cliki.net/index,in
+the Web Archive}.
 
 Some low-level information describing the programming details of the
 conversion from CMUCL to SBCL is available in the
-@file{doc/FOR-CMUCL-DEVELOPERS} file in the SBCL distribution, though
-it is not installed by default.
+@file{doc/FOR-CMUCL-DEVELOPERS} file in the SBCL distribution and
+@uref{https://sourceforge.net/p/sbcl/sbcl/ci/master/tree/doc/FOR-CMUCL-DEVELOPERS,on
+SourceForge}.
 
 @node More Common Lisp Information
 @comment  node-name,  next,  previous,  up
@@ -465,10 +469,10 @@ it is not installed by default.
 @c FIXME: Say something smart here
 
 The Common Lisp internet community is fairly diverse:
-@uref{news://comp.lang.lisp} is fairly high volume newsgroup, but has
+@uref{https://groups.google.com/g/comp.lang.lisp} is fairly high volume newsgroup, but has
 a rather poor signal/noise ratio. Various special interest mailing
 lists and IRC tend to provide more content and less flames.
-@uref{http://www.lisp.org} and @uref{http://www.cliki.net} contain
+@uref{https://www.lisp.org} and @uref{https://cliki.net} contain
 numerous pointers places in the net where lispers talks shop.
 
 @node Third-party Libraries
@@ -476,7 +480,7 @@ numerous pointers places in the net where lispers talks shop.
 @subsection Third-party Libraries
 
 For a wealth of information about free Common Lisp libraries and tools
-we recommend checking out @emph{CLiki}: @uref{http://www.cliki.net/}.
+we recommend checking out @emph{CLiki}: @uref{https://cliki.net/}.
 
 @node Common Lisp Books
 @comment  node-name,  next,  previous,  up
@@ -485,7 +489,8 @@ we recommend checking out @emph{CLiki}: @uref{http://www.cliki.net/}.
 If you're not a programmer and you're trying to learn, many
 introductory Lisp books are available. However, we don't have any
 standout favorites. If you can't decide, try checking the Usenet
-@uref{news://comp.lang.lisp} FAQ for recent recommendations.
+@uref{https://groups.google.com/g/comp.lang.lisp} FAQ for recent
+recommendations.
 
 @c FIXME: This non-stance is silly. Maybe we could recommend SICP,
 @c Touretzky, or something at least.
@@ -498,7 +503,7 @@ learn about Common Lisp, some books stand out:
 @item Practical Common Lisp, by Peter Seibel
 An excellent introduction to the language, covering both the basics
 and ``advanced topics'' like macros, CLOS, and packages. Available
-both in print format and on the web: @uref{http://www.gigamonkeys.com/book/}.
+both in print format and on the web: @uref{https://gigamonkeys.com/book/}.
 
 @item Paradigms Of Artificial Intelligence Programming, by Peter Norvig
 Good information on general Common Lisp programming, and many
@@ -510,7 +515,7 @@ An in-depth treatment of macros, but not recommended as a first Common
 Lisp book, since it is slightly pre-ANSI so you need to be on your
 guard against non-standard usages, and since it doesn't really even
 try to cover the language as a whole, focusing solely on macros.
-Downloadable from @uref{http://www.paulgraham.com/onlisp.html}.
+Downloadable from @uref{https://www.paulgraham.com/onlisp.html}.
 
 @item Object-Oriented Programming In Common Lisp, by Sonya Keene
 With the exception of @cite{Practical Common Lisp} most introductory
@@ -560,8 +565,8 @@ storage to be specified at compile time.
 @item
 The system overcommits memory, allocating large amounts of address
 space from the system (often more than the amount of virtual memory
-available) and then failing if ends up using too much of the allocated
-storage.
+available) and then failing if it ends up using too much of the
+allocated storage.
 
 @item
 The system is implemented as a C program which is responsible for
-- 
2.39.3 (Apple Git-145)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.