Re: [Sbcl-commits] master: Don't fmakunbound functions present in *handled-conditions*

--===============2405550269247230305==
Content-Type: multipart/alternative; boundary="000000000000d585ef0656bc6338"

--000000000000d585ef0656bc6338
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

That change isn't doing what it says in the commit message. I would expect
based on seeing the commit that it tests for presence in
*handled-conditions*.
Please work on writing accurate descriptions.  And please restore the
ability to load this file more than once without causing a style warning

On Thu, Jul 16, 2026 at 11:11=E2=80=AFAM stassats via Sbcl-commits <
[email protected]> wrote:

> The branch "master" has been updated in SBCL:
>        via  e3c2db021f4f5138ec1f04b3c0c83148c362a45d (commit)
>       from  eda10e3e572cd31b257c27ed1a71682a9892c468 (commit)
>
> - Log -----------------------------------------------------------------
> commit e3c2db021f4f5138ec1f04b3c0c83148c362a45d
> Author: Stas Boukarev <[email protected]>
> Date:   Thu Jul 16 17:57:02 2026 +0300
>
>     Don't fmakunbound functions present in *handled-conditions*
>
>     Otherwise they themselves can't be compiled.
> ---
>  src/cold/muffler.lisp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/cold/muffler.lisp b/src/cold/muffler.lisp
> index fb3b019a0..1eadd20bc 100644
> --- a/src/cold/muffler.lisp
> +++ b/src/cold/muffler.lisp
> @@ -17,7 +17,6 @@
>
>  ;; This avoids muffling "could not optimize away %SAP-ALIEN"
>  ;; and "SAP to pointer conversion" in case we care.
> -(fmakunbound 'unable-to-optimize-note-p)
>  (defun unable-to-optimize-note-p (condition)
>    (and (string=3D (type-of condition) "SIMPLE-COMPILER-NOTE")
>         (let ((fc (simple-condition-format-control condition)))
> @@ -31,7 +30,6 @@
>  (defvar *optional-and-key-warning-condition*
>    (find-symbol "&OPTIONAL-AND-&KEY-IN-LAMBDA-LIST" "SB-KERNEL"))
>
> -(fmakunbound 'optional+key-style-warning-p)
>  (defun optional+key-style-warning-p (condition)
>    #+sbcl
>    (when *optional-and-key-warning-condition*
>
> -----------------------------------------------------------------------
>
>
> hooks/post-receive
> --
> SBCL
>
>
> _______________________________________________
> Sbcl-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/sbcl-commits
>

--000000000000d585ef0656bc6338
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">That change isn&#39;t doing what it says =
in the commit message.=C2=A0I would expect based on seeing the commit that =
it tests for presence in *handled-conditions*.</div><div>Please work on wri=
ting accurate descriptions.=C2=A0 And please restore the ability to load th=
is file more than once without causing a style warning</div><div><br></div>=
<div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"=
gmail_attr">On Thu, Jul 16, 2026 at 11:11=E2=80=AFAM stassats via Sbcl-comm=
its &lt;<a href=3D"mailto:[email protected]">sbcl-commits@=
lists.sourceforge.net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">The branch &quot;master&quot; has been updated in SBCL=
:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0via=C2=A0 e3c2db021f4f5138ec1f04b3c0c83148c362a4=
5d (commit)<br>
=C2=A0 =C2=A0 =C2=A0 from=C2=A0 eda10e3e572cd31b257c27ed1a71682a9892c468 (c=
ommit)<br>
<br>
- Log -----------------------------------------------------------------<br>
commit e3c2db021f4f5138ec1f04b3c0c83148c362a45d<br>
Author: Stas Boukarev &lt;<a href=3D"mailto:[email protected]" target=3D"_=
blank">[email protected]</a>&gt;<br>
Date:=C2=A0 =C2=A0Thu Jul 16 17:57:02 2026 +0300<br>
<br>
=C2=A0 =C2=A0 Don&#39;t fmakunbound functions present in *handled-condition=
s*<br>
<br>
=C2=A0 =C2=A0 Otherwise they themselves can&#39;t be compiled.<br>
---<br>
=C2=A0src/cold/muffler.lisp | 2 --<br>
=C2=A01 file changed, 2 deletions(-)<br>
<br>
diff --git a/src/cold/muffler.lisp b/src/cold/muffler.lisp<br>
index fb3b019a0..1eadd20bc 100644<br>
--- a/src/cold/muffler.lisp<br>
+++ b/src/cold/muffler.lisp<br>
@@ -17,7 +17,6 @@<br>
<br>
=C2=A0;; This avoids muffling &quot;could not optimize away %SAP-ALIEN&quot=
;<br>
=C2=A0;; and &quot;SAP to pointer conversion&quot; in case we care.<br>
-(fmakunbound &#39;unable-to-optimize-note-p)<br>
=C2=A0(defun unable-to-optimize-note-p (condition)<br>
=C2=A0 =C2=A0(and (string=3D (type-of condition) &quot;SIMPLE-COMPILER-NOTE=
&quot;)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((fc (simple-condition-format-control cond=
ition)))<br>
@@ -31,7 +30,6 @@<br>
=C2=A0(defvar *optional-and-key-warning-condition*<br>
=C2=A0 =C2=A0(find-symbol &quot;&amp;OPTIONAL-AND-&amp;KEY-IN-LAMBDA-LIST&q=
uot; &quot;SB-KERNEL&quot;))<br>
<br>
-(fmakunbound &#39;optional+key-style-warning-p)<br>
=C2=A0(defun optional+key-style-warning-p (condition)<br>
=C2=A0 =C2=A0#+sbcl<br>
=C2=A0 =C2=A0(when *optional-and-key-warning-condition*<br>
<br>
-----------------------------------------------------------------------<br>
<br>
<br>
hooks/post-receive<br>
-- <br>
SBCL<br>
<br>
<br>
_______________________________________________<br>
Sbcl-commits mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">Sbc=
[email protected]</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/sbcl-commits" rel=
=3D"noreferrer" target=3D"_blank">https://lists.sourceforge.net/lists/listi=
nfo/sbcl-commits</a><br>
</blockquote></div></div>

--000000000000d585ef0656bc6338--


--===============2405550269247230305==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============2405550269247230305==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Sbcl-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sbcl-devel

--===============2405550269247230305==--