&KEY parameters in DEFGENERIC

Edi Weitz <[email protected]> 24 Dec 2002 01:03:58 +0100
Newsgroups gmane.lisp.uncommon-sql
Message-ID <[email protected]>
I upgraded from CMUCL 18d+ to 18e-pre a couple of days ago and noticed
that UncommonSQL doesn't work anymore. Here are a couple of simple
patches required to make it work again.

Nice Christmas Holidays to all,
Edi.



diff -ru /tmp/uncommonsql.orig/sql/dbms-interface.lisp /usr/local/lisp/source/uncommonsql/sql/dbms-interface.lisp
--- /tmp/uncommonsql.orig/sql/dbms-interface.lisp       Tue Dec 24 00:57:08 2002
+++ /usr/local/lisp/source/uncommonsql/sql/dbms-interface.lisp  Tue Dec 24 00:47:57 2002
@@ -87,13 +87,13 @@
   (:documentation "Return the type SQL type specifier as a string, for
 the given lisp type and parameters."))

-(defgeneric database-list-tables (database &key (system-tables nil))
+(defgeneric database-list-tables (database &key system-tables)
   (:documentation "List all tables in the given database"))

-(defgeneric database-list-sequences (database &key (system-sequences nil))
+(defgeneric database-list-sequences (database &key system-sequences)
   (:documentation "List all sequences in the given database"))

-(defgeneric database-list-indexes (database &key (system-indexes nil))
+(defgeneric database-list-indexes (database &key system-indexes)
   (:documentation "List all indexes in the given database"))

 (defgeneric database-indexp (database idxname)
diff -ru /tmp/uncommonsql.orig/sql/sql.lisp /usr/local/lisp/source/uncommonsql/sql/sql.lisp
--- /tmp/uncommonsql.orig/sql/sql.lisp  Tue Dec 24 00:57:09 2002
+++ /usr/local/lisp/source/uncommonsql/sql/sql.lisp     Tue Dec 24 00:48:55 2002
@@ -278,7 +278,7 @@

 ;;; Basic operations on databases

-(defgeneric query (query-expression &key (database *default-database*))
+(defgeneric query (query-expression &key database)
   (:documentation
    "Execute the SQL query expression query-expression on the given database.
 Returns a list of lists of values of the result of that expression."))