Re: ... convert_unicode.c ...

Matthias Andree <[email protected]>
Newsgroups gmane.mail.bogofilter.devel
Message-ID <[email protected]>
David Relson <[email protected]> writes:

> The question of the moment is what to do when iconv_open() fails.  As
> you suggest we could just ignore the message.  That seems like a bad
> idea as one could just add a dummy mime body section with a bogus
> charset and bogofilter would be disabled.  Not good!

Right you are - the question is what will mailers present to the user
with strange character sets? We should probably log these for a while to
obtain relevant information.

> It would be better to turn off translation and simply parse whatever
> text is present. Translation will resume at the next 
> "Content-Type: ... charset=" directive.  True, some untranslated text
> would be passed through, but the impact would probably be minor.

I'm a bit concerned about storing non-UTF-8 tokens in a database that
claims UTF-8 format. This is a can of worms we can avoid - like reading
the database back to show it to the user (we don't do that yet) fails
with EILSEQ or similar.

-- 
Matthias Andree
_______________________________________________
Bogofilter-dev mailing list
[email protected]
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.