Re: included-gsl patch

Torsten Veller <[email protected]> writes:

> Hi,
>
> attached is a patch for included-gsl check. I think it is correct.
>
> --with-included-gsl           -->  need_my_gsl=2
> --wihout-included-gsl or none -->  need_my_gsl=1
>
> It uses the included gsl if requested and
> checks if the libs are installed, if either 
> --without or nothing is passed to configure.
> If they don't exist, the included lib is used.
>
>
> BTW: my gcc (4.0.1) thinks it should point out:
>      note: obsolete option -I- used, please use -iquote instead

Quite disturbing, as it encourages replacing one construct by one that
is even less portable. Please report a regression bug to GCC.

> --- configure.ac~	2005-09-06 01:52:58.000000000 +0200
> +++ configure.ac	2005-09-06 01:53:13.000000000 +0200
> @@ -695,7 +695,7 @@
>  
>  need_my_gsl=1
>  AC_ARG_WITH(included-gsl, AC_HELP_STRING([--with-included-gsl],[force use of shipped GSL rather than system GSL]),
> -if test "x$WITHVAL" != "xyes" ; then need_my_gsl=2 ; fi)
> +if test "x$withval" = "xyes" ; then need_my_gsl=2 ; fi)
>  
>  if test "$need_my_gsl" = 1 ; then
>    AM_PATH_GSL(1.4,

I see this has been merged. Thanks a lot for your patch.

-- 
Matthias Andree
_______________________________________________
Bogofilter-dev mailing list
[email protected]
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev