Re: [cvs] bogofilter/contrib randomtrain.sh, NONE, 1.1 scramble.sh, NONE, 1.1 randomtrain.bash, 1.1, NONE scramble.bash, 1.1, NONE

David Relson <[email protected]> writes:

> Update of /cvsroot/bogofilter/bogofilter/contrib
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12644
>
> Added Files:
> 	randomtrain.sh scramble.sh 
> Removed Files:
> 	randomtrain.bash scramble.bash 
> Log Message:
> Rename *.bash to *.sh

Please do not assume all bash scripts worked on a regular POSIX
sh. There are systems (lots of them actually) where bash != sh and where
sh cannot digest a *.bash script, particularly if the noise word
"function" is used or bash-specific substring word expansions such as
${NAME:EXPR:EXPR} are used.

There was a reason why I called them .bash and not .sh.

I've now fixed the obvious bashisms in randomtrain.sh so that "/bin/sh
-n randomtrain.sh" now passes on FreeBSD 4.11 and "/usr/xpg4/bin/sh -n
randomtrain.sh" passes on Solaris 8.

Same commands with "scramble.sh" passed on either system, so I've just
added a note to use /usr/xpg4/bin/sh on Solaris to either file.

As I did not conduct a full test, we need someone who uses these scripts
regularly to test them and see if they still work as expected.

-- 
Matthias Andree
_______________________________________________
Bogofilter-dev mailing list
[email protected]
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev