Re: renamed scripts [was: [cvs] bogofilter/contrib ...]

It seems to me that the names of the scripts are unimportant (other
than as a visual hint) and that it is the magic cookie in the first
line that is what should be discussed.  If a script is bash specific,
I think it ought to open with #!/bin/bash rather than #!/bin/sh.  Just
my two cents.

--Larry

On Thu, Oct 27, 2005 at 07:17:17AM -0400, David Relson wrote:
> On Thu, 27 Oct 2005 09:57:35 +0200
> Matthias Andree wrote:
> 
> > David Relson <[email protected]> writes:
> > 
> > > Update of /cvsroot/bogofilter/bogofilter/contrib
> > > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12644
> > >
> > > Added Files:
> > > 	randomtrain.sh scramble.sh 
> > > Removed Files:
> > > 	randomtrain.bash scramble.bash 
> > > Log Message:
> > > Rename *.bash to *.sh
> > 
> > Please do not assume all bash scripts worked on a regular POSIX
> > sh. There are systems (lots of them actually) where bash != sh and where
> > sh cannot digest a *.bash script, particularly if the noise word
> > "function" is used or bash-specific substring word expansions such as
> > ${NAME:EXPR:EXPR} are used.
> > 
> > There was a reason why I called them .bash and not .sh.
> > 
> > I've now fixed the obvious bashisms in randomtrain.sh so that "/bin/sh
> > -n randomtrain.sh" now passes on FreeBSD 4.11 and "/usr/xpg4/bin/sh -n
> > randomtrain.sh" passes on Solaris 8.
> > 
> > Same commands with "scramble.sh" passed on either system, so I've just
> > added a note to use /usr/xpg4/bin/sh on Solaris to either file.
> > 
> > As I did not conduct a full test, we need someone who uses these scripts
> > regularly to test them and see if they still work as expected.
> 
> AFAIK, none of the contrib scripts are widely used and their names are
> of little importance.  Since bash is the standard shell of the most 
> common platform for bogofilter and since sh is commonly a symlink, I'd
> be inclined to _not_ change names of either sh or bash scripts.  
> _______________________________________________
> Bogofilter-dev mailing list
> [email protected]
> http://www.bogofilter.org/mailman/listinfo/bogofilter-dev

-- 
Larry Fahnoe, Fahnoe Technology Consulting, [email protected]
952/925-0744      Minneapolis, Minnesota       www.FahnoeTech.com 
_______________________________________________
Bogofilter-dev mailing list
[email protected]
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev