Re: Automatic Refresh for local Maildir's mail counts

Sam Varshavchik <[email protected]> Wed, 01 Feb 2017 21:44:39 -0500
Newsgroups gmane.mail.cone
Message-ID <[email protected]>
This is a MIME GnuPG-signed message.  If you see this text, it means that
your E-mail or Usenet software does not support MIME signed messages.
The Internet standard for MIME PGP messages, RFC 2015, was published in 1996.
To open this message correctly you will need to install E-mail or Usenet
software that supports modern Internet standards.

--===============1237286591756907681==
Content-Type: multipart/signed;
	boundary="=_monster.email-scan.com-18243-1486003479-0001";
	micalg=pgp-sha1; protocol="application/pgp-signature"

This is a MIME GnuPG-signed message.  If you see this text, it means that
your E-mail or Usenet software does not support MIME signed messages.
The Internet standard for MIME PGP messages, RFC 2015, was published in 1996.
To open this message correctly you will need to install E-mail or Usenet
software that supports modern Internet standards.

--=_monster.email-scan.com-18243-1486003479-0001
Content-Type: text/plain; format=flowed; delsp=yes; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Linux-Fan writes:

> It is not using a pipe, but a C++11 std::atomic instead. If that cannot
> be used, because Cone needs to compile without C++11 (I used
> `./configure CPPFLAGS=-std=c++11` to get it to work), I'd replace this
> by a variable which is marked `volatile sig_atomic_t`.

Cone is still compiled on relatively old platforms. C++11 is not a viable  
option right now; but probably in a little while this would be an option.

I do not see a good reason not to use an internal pipe, in non-blocking  
mode, and with O_CLOEXEC set. sig_atomic_t has been around only since C99;  
but I suppose at this time requiring C99 would be acceptable.

> What do you think? Does it make sense to put it that way or have I
> misplaced the call to `processHierharcyRefresh()`? Is it better to use
> `SA_RESTART` or not? I am not quite sure...
> Also, in order to improve the folder refreshing mechanism, I have
> implemented a `RefreshIterator` which uses `updateInfo` on all folder
> entries. Have I used the API correctly?

I would have to look at this closer, to determine the right answer.

> By the way: If you wonder about the `masysma` prefixes and annotations:
> I will happily remove these if the patch has a chance of being
> incorporated but for now I have added them to easily navigate to my
> modifications within the code and make sure I do not confuse my
> changes with what was already there...

No big rush here. You can take your time and test your changes thoroughly.  
In general, this looks fine but I have not had a closer look; but I will  
consider it. A few procedural things will need to happen for that; but that  
can be left for later...



--=_monster.email-scan.com-18243-1486003479-0001
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIcBAABAgAGBQJYkp0XAAoJEGs6Yr4nnb8lvqwP/2ntDTRAn8w/275JfyUEE1iP
9OycURQkummq1FknLRVxEFFAthLw5pubZX1cdwJDpuW7ji1vRnvtW2I5QrDKK0BG
k4Rd3Y4F39M39n4ZMIx6PQOxUVPPdARXvVXLXXs2L3INAvz5NKSGGU9rNlYs2HlE
hm1LG/sP7tM60Dy2KkG74s7b6mBHzr7/7cmYMRPejUXg7A0lxwLaGzEL94AtFQ9e
txVlfIOTrOkSnOn+46kRgDIxZ9vKYrcy4BnwXSuGCDzTGzLzuSdIsYbc75nxy96l
4Jsud+XXBkETv/MUIBRWM0YFAZmLSR35PGaa9zWSyTQzH7wNsMVvrfOA+v5Li/H/
EdCzxCf6cD5BCX6nonBmIGtQda/pncrFnzY1D3AaEpI/L2mMhi56vVo4r6jSwvdA
PgeHIdfxw72bOv6UoSiBAgzPp1p8AbJLcEtT/L/JAgyAToaRsXlpyYVSsztM3wxs
cJvugTZAISbeIftgaaWminOYhiA8ZlchiF+c2bHnbMNgM6t2+Of+FdxEM91vgQBd
yQL8cJn9ZFhkiTUWJ0HEYIJYpkJiOcfp/eDSJr2gItPAjizBnXnt8IYABCclN8jF
XY0Fklkafj6t7vZg1ze3ZA9gNz4b+5kGaa1HEaHf0DIx8lfzXfTcb1RGm2ZImmCE
oO7pucL4Tv7SzqVT3pEs
=LxjI
-----END PGP SIGNATURE-----

--=_monster.email-scan.com-18243-1486003479-0001--


--===============1237286591756907681==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
--===============1237286591756907681==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Courier-cone mailing list
[email protected]
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-cone

--===============1237286591756907681==--