Re: SA-exim 4.0 crashes on discard

On Fri, 2004-03-26 at 10:40, John Horne wrote:
>
> I noticed on our mailhubs that some mail was being delivered to userids
> beginning with a hyphen. We have no such userids so I modified exim to
> discard these. This was before installing sa-exim 4.0 - and it worked
> okay. I have now installed sa-exim onto our second mailhub and in
> testing that mail sent to '[email protected]' was discarded/rejected I got
> the following error in the main and reject logs, there is no panic log:
> 
> ============================================
> 2004-03-26 10:22:13 H=(jhorne.csd.plymouth.ac.uk) [141.163.60.243]
> F=<[email protected]> rejected RCPT <[email protected]>: discarded by
> RCPT ACL: Prohibited: Invalid local part being received.
> 2004-03-26 10:22:13 1B6oTd-00066Y-Lr local_scan() function crashed with
> signal 11 - message temporarily rejected (size 736)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
The problem seems to stem from the fact that by discarding the
recipient(s) the local_scan function can be called with no recipients
left. However, there is no check for this.

I modified sa-exim. to simply say (at line 721):

   /* Initialize the list of recipients here */
        if (recipients_count == 0) {
                return LOCAL_SCAN_ACCEPT;
        }
    rcptlist=string_copy(recipients_list[0].address);

and this seems to work fine. If there are no recipients then exim
blackholes the message after local_scan has run.


Regards,

John.

-- 
---------------------------------------------------------------
John Horne, University of Plymouth, UK  Tel: +44 (0)1752 233914
E-mail: [email protected]       Fax: +44 (0)1752 233839