Re: SA-exim 4.0 crashes on discard

On Fri, Mar 26, 2004 at 01:38:21PM +0000, John Horne wrote:
> On Fri, 2004-03-26 at 13:18, Sander Smeenk wrote:
> > Quoting John Horne ([email protected]):
> > 
> > > > 2004-03-26 10:22:13 1B6oTd-00066Y-Lr local_scan() function crashed with
> > > > signal 11 - message temporarily rejected (size 736)
> > > I modified sa-exim. to simply say (at line 721):
> > >    /* Initialize the list of recipients here */
> > >         if (recipients_count == 0) {
> > >                 return LOCAL_SCAN_ACCEPT;
> > 
> > Hmm. Isn't this an exim bug, rather than a sa-exim bug?
> > 
> > I mean, if the message has been disgarded, what is the use of passing it
> > to local_scan() in the first place?
> > 
> Because local_scan may create recipients. However, in our case we don't
> so the patch above works, but it obviously won't work for everyone. The
> point is that some check needs to occur because it is valid to send a
> message to local_scan with no recipients on the basis that it may create
> some.
 
This did not even occur to me, thanks for the report, and especially for
finding the reason.

I'm wondering how many people this can affect and whether it warrants a
4.0.1 or not. I'm guessing that the occurrence is not common enough to have
affected anyone else in the 1y+ since that piece of code has been there, but
there's definitely potential for this to happen to others.

I think I'll give it a few more weeks to see if there are other bugs or
problems reported by other folks, and make a new release with all the fixes
then.

I'll put a note on the web site in the meantime

Thanks
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/   |   Finger [email protected] for PGP key