Re: Problem with the logging patch of the other day

Marc MERLIN <[email protected]>
Newsgroups gmane.mail.exim.spamassassin
Message-ID <[email protected]>
On Wed, Jan 01, 2003 at 09:11:34AM -0500, Brian Kendig wrote:
> Marc -- there's a slight problem with the patch you did the other day 
> to avoid writing that 'savemail condition expand returned false' line 
> to the log every time.  The problem is that, now, all incoming mail 
> gets logged, even when it's not supposed to be.
 
Yes, you are absolutely right, that's what I get for coding while being
jetlagged, and a bit sick due to too much food :)
 
> I think you want something like this instead:
> 
> if (expand[0] == 0 || (expand[0] == '0' && expand[1] == 0))
> {
>     if (SAEximDebug > 1)
>     {
>         log_write(0, LOG_MAIN, "SA: savemail condition expanded to 
> false, not saving message to disk");
>     }
>     return 0;
> }

Absolutely, I just checked that in.

Thanks for reviewing my cvs patch

Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems & security ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/   |   Finger [email protected] for PGP key
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.