Re: Oversigning Resent-xxx headers

Andrew C Aitchison via Exim-users <[email protected]>
Newsgroups gmane.mail.exim.user
Message-ID <[email protected]>
On Mon, 28 Jul 2025, Andreas Metzler via Exim-users wrote:

> On 2025-07-28 Jeremy Harris via Exim-users <[email protected]> wrote:
>> On 2025/07/27 10:40 AM, Slavko via Exim-users wrote:
>>> Jeremy, Heiko, please, are you willing to change this?
>
>> (copied from IRC)
>> it's a whole bunch of work, more than just replacing a couple of
>> strings.  I have very little enthusiasm for it
>
> Hmm,
>
> could you expand on that? I would have expected that
>
> * changing #define PDKIM_DEFAULT_SIGN_HEADERS in
>  src/src/miscmods/pdkim/pdkim.h
> * Updating the docs, including a proper entry for doc/doc-txt/ChangeLog
> * Handling possible testsuite failures.
>
> would benough. (Which obviously is "more than just replacing a couple
> of strings".)

My guess is that someone may need to write some new tests,
or at least verify that no new tests are needed.

Since it is only changing a default, there should already be tests for all 
the consequences, but there may be tests no onehas so far thought to do ?

That might boil down to "handling possible testsuite failures",
but someone needs to understand the issue well enough to know
that all the thigs that need testing are tested for.

-- 
Andrew C. Aitchison                      Kendal, UK
                    [email protected]

-- 
## subscription configuration (requires account):
##   https://lists.exim.org/mailman3/postorius/lists/exim-users.lists.exim.org/
## unsubscribe (doesn't require an account):
##   [email protected]
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.