Re: Attaching messages with 2004/10/11 snapshot

On Thu, 14 Oct 2004 10:46:25 BST, George Ross said:

> Attaching messages doesn't work with the 2004/10/11 CVS snapshot either 
> without the following patch:
> 
> --- /tmp/exmh-2.7.0_20041012/lib/fileselect.tcl 2004-07-19 06:00:07.000000000
 +0100
> +++ /usr/lib/exmh2-2.7.1/fileselect.tcl 2004-10-14 10:40:22.000000000 +0100
> @@ -64,8 +64,9 @@
>      global fileselect
>      global exwin
>  
> -    # Smash out anything that isn't alphanumeric, period, underscore or dash
> -    regsub -all {[^[:print:]._-]+} $defaultName _ defaultName
> +    # Smash out anything that isn't alphanumeric, period, underscore,
> +    # slash or dash
> +    regsub -all {[^[:print:]._/-]+} $defaultName _ defaultName
>      # Oh, and too many things treat dot-files as special...
>      regsub {^\.+} $defaultName _ defaultName
> 
> I presume '/' was dropped to protect the other case where FSBox is passed a 
> default, viz saving a MIME part.  Perhaps it needs to have some way to 
> distinguish the two cases?

Yes, '/' was intentionally excluded for the saving-a-MIME-part case.
I hadn't noticed a problem when attaching a regular file, but failed to
consider the attach-a-message case.

The proper fix would be to pass a flag, and only do the smashing when
*saving* a MIME part - there's no exposure if the user is selecting an
already-existing file to attach to outbound mail, as the problem is
for inbound mail only...

_______________________________________________
Exmh-workers mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/exmh-workers

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFBbqYXcC3lWbTT17ARAkC4AKDI9WMJMV7Aye1Nv694A25LfUQRCgCfZ/2M
ZzNpE45NA72Mi9aPK+RVcK8=
=i0+z
-----END PGP SIGNATURE-----