Re: pre-announce exmh-2.7.2
Brent Welch <[email protected]>
| Newsgroups | gmane.mail.exmh.devel |
|---|---|
| Message-ID | <[email protected]> |
Hmm - I added logging, and the trace also fires multiple times when manipulating the unseen count for a single folder. The way you've cleaned up the code, all the accounting is done in just one or two places now, so I convinced myself that I was handling all the updates correctly. Plus, I can't duplicate the bug John Beck reported... which he says is a minor issue that the current folder doesn't show up in the unseen sequences listing right after he starts up. Works for me, however. >>>Chris Garrigues said: > > From: Brent Welch <[email protected]> > > Date: Wed, 05 Jan 2005 16:01:40 -0800 > > > > OK, I did make changes in the places where the sequence window gets > > updated. I got rid of a variable trace and make explicit calls. I > > hoping that means I can add an explicit call at the end of startup > > and that will fix things... (Seq_Trace became SeqCount) > > BTW, the reason I did that as a variable trace instead of explicit calls > in > the first place was because in the previous code there were lots of > cases > where the explicit calls happened multiple times and as I tried to clean > them > up, I found myself chasing difficult screw cases all over the place. > Eventually I simplified things a whole lot by doing the variable trace > and > deleting all the explicit calls. > > Unless you have a bunch of time available to chase this down all the > different > paths through the code before you do a release, you may want to back out > that > change. > > Chris > > -- > Chris Garrigues Trinsic Solutions > President 1611-B West 6th Street > Austin, TX 78703-5074 > > 512-322-0180 http://www.trinsics.com > > Would you rather proactively pay for > uptime or reactively pay for downtime? > > Trinsic Solutions > Your Proactive IT Management Partner > -- Brent Welch Software Architect, Panasas Inc Delivering the premier storage system for scalable Linux clusters www.panasas.com [email protected]