Re: svn commit: r8632 - trunk/tools/cvs2svn

[email protected] writes:

> Author: kfogel
> Date: Fri Feb 13 11:26:50 2004
> New Revision: 8632
> 
> Modified:
>    trunk/tools/cvs2svn/dump-db.py
> Log:
> Extend debugging tool as part of work on issue #1510:
> 
> * tools/cvs2svn/dump-db.py
>   (main): Handle unmarshalled data too.

When I saw this, I started to revert my cvs2svn.py change of revision
8547 (which started marshaling the revisions db data so dump-db.py
could deal with it), but it seems that some of our revision data
*does* look similar enough to marshaled data -- when I reverted the
that change locally, I actually got a SEGFAULT in Python (repeatedly,
not a fluke case) trying to use dump-db.py on now-unmarshaled
cvs2svn-revisions.db!

I think for consistency (yes, at the cost of the marshaling), I'd
prefer to keep all our .db data marshalled.  Besides, if we change the
format of those database values, we don't have to remember to start
marshaling it later.