Re: svn commit: r9280 - in trunk/subversion: include libsvn_delta

[email protected] wrote:

>Author: bliss
>Date: Sat Apr  3 09:22:48 2004
>New Revision: 9280
>
>Modified:
>   trunk/subversion/include/svn_types.h
>   trunk/subversion/libsvn_delta/text_delta.c
>Log:
>Break apart the stream chunk size and the svndiff window size and
>reduce the chunk size to 8 kiB because it consumes less stack, is
>more TLB/cache friedly and is actually faster on some OSes.  This
>also fixes "svn cat" for large files on Win32.
>
>* subversion/include/svn_types.h
>  (SVN_STREAM_CHUNK_SIZE): Reduce from 100 kiB to 8 kiB.
>  (SVN_MAX_OBJECT_SIZE): Remove strange FIXME.
>  
>
I object to this last bit. It is not a "strange FIXME", it's a question
that needs to be answered before doing anything about it. Just removing
the comment doesn't answer the question, and you didn't even try to
analyse the pros and cons of making max-window-size the same as
stream-chunk-size.

>* subversion/libsvn_delta/text_delta.c
>  (SVN_DELTA_WINDOW_SIZE): New define to use for the svndiff window
>  size instead of SVN_STREAM_CHUNK_SIZE.
>  (svn_txdelta, svn_txdelta_next_window): Use SVN_DELTA_WINDOW_SIZE.
>  
>
I believe you missed at least fs-test. Your change modifies the
semantics of the file integrity tests.


-- 
Brane Čibej   <[email protected]>   http://www.xbc.nu/brane/