Re: svn commit: r9709 - trunk/subversion/libsvn_client

C. Michael Pilato wrote:
> Josh, could you a) fix the comment which is above the `change =
> apr_hash_get' line to reflect the new truth, and maybe simplify the
> logic above with an extra level of indentation?  Something like:
> 
>    /* See if PATH was explicitly changed in this revision. */
>    change = apr_hash_get (changed_paths, path, APR_HASH_KEY_STRING);
>    if (change)
>      {
>        /* If PATH was not newly added in this revision, then it may or may
>           not have also been part of a moved subtree.  In this case, set a
>           default previous path, but still look through the parents of this
>           path for a possible copy event. */
>        if (change->action != 'A' && change->action != 'R')
>          {
>            prev_path = path;
>          }
>        else
>          {
>            /* PATH is new in this revision.  This means it cannot have been
>               part of a copied subtree. */
>            if (change->copyfrom_path)
>              prev_path = apr_pstrdup (pool, change->copyfrom_path);
>      
>            *prev_path_p = prev_path;
>            if (action_p)
>              *action_p = change->action;
>            if (copyfrom_rev_p)
>              *copyfrom_rev_p = change->copyfrom_rev;
>            return SVN_NO_ERROR;
>          }
>      }
>    [...]

Thanks for the feedback.  It should be all cleaned up in r9711.

-Josh