Re: svn commit: r10114 - in trunk: . subversion/include subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline

Branko Čibej <[email protected]> Fri, 02 Jul 2004 01:46:30 +0200

Newsgroups	gmane.comp.version-control.subversion.svn,gmane.mail.eyebrowse.devel
Message-ID	<[email protected]>

Josh Pieper wrote:

>Branko ??ibej wrote:
>  
>
>>[email protected] wrote:
>>
>>    
>>
>>>+          /* On Win32, CreateFile failswith an "Access Denied" error
>>>+             code, rather than "File Already Exists", if the colliding
>>>+             name belongs to a directory. */
>>>
>>>
>>>      
>>>
>>Isn't this Win32-specific comment inside an '#ifdef HAVE_SYMLINK' 
>>somewhat strange?
>>    
>>
>
>Well, I believe it was you who said we should test for features, not
>platforms.  There might be some platform that supports symlinks, but
>does return the access denied error...
>  
>
Hm. O.K.

We're going to have to solve this platform-specific mess in a more 
consistent way soon. We're piling hacks upon hacks. Yah. Seems to me we 
need a portability guideline document (or section in HACKING). There are 
some things APR simply isn't intended to handle.

-- Brane