Re: svn commit: r10772 - trunk/subversion/libsvn_client

Mark Benedetto King <mbk-5CV/[email protected]> Mon, 30 Aug 2004 10:55:44 -0400

Newsgroups	gmane.comp.version-control.subversion.svn,gmane.mail.eyebrowse.devel
Message-ID	<[email protected]>

On Mon, Aug 30, 2004 at 05:44:47AM -0500, [email protected] wrote:
>  
> -  if ((entry->kind == svn_node_file)
> -      && (! propval)
> -      && (is_special))
> +  if (((! propval) && (is_special)) ||
> +          ((propval) && (! is_special)))
>      {

An alternative form:

     if ((! propval) != (! is_special))
       {

Ignoring readability, there is a performance reason for this change:
most C optimizers aren't smart enough to prove that the original's
short-circuiting branches are unneccesary.

--ben