Re: svn commit: r8341 - trunk/subversion/libsvn_subr

Branko Čibej <[email protected]> Fri, 16 Jan 2004 22:41:02 +0100

Newsgroups	gmane.mail.eyebrowse.devel,gmane.comp.version-control.subversion.svn
Message-ID	<[email protected]>

Jani Averbach wrote:

>I think it is better to use construction:
>
>#ifdef WIN32
>#define WIN32_RETRY_LOOP(err, expr) \
>    do { \
>      ... \
>    while(0)
>  
>
That's fine, but, uh,

>#else
>#define WIN32_RETRY_LOOP(err, expr) do {} while(0)
>#endif
>  
>
Why would you want to define an empty loop? Just defining the macro to
an empty string will do the same job and be more concise.

An C statement can be empty. The following

    void foo(void)
    {
      ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
    }

is a valid C program.


-- 
Brane Čibej   <[email protected]>   http://www.xbc.nu/brane/