Re: svn commit: r11892 - in trunk/subversion: libsvn_delta libsvn_diff libsvn_ra_dav libsvn_ra_local libsvn_subr libsvn_wc

[email protected] wrote:

>Modified: trunk/subversion/libsvn_subr/config_impl.h
>Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_subr/config_impl.h?view=diff&rev=11892&p1=trunk/subversion/libsvn_subr/config_impl.h&r1=11891&p2=trunk/subversion/libsvn_subr/config_impl.h&r2=11892
>==============================================================================
>--- trunk/subversion/libsvn_subr/config_impl.h	(original)
>+++ trunk/subversion/libsvn_subr/config_impl.h	Sat Nov 13 21:42:25 2004
>@@ -26,7 +26,6 @@
> 
> #include <apr_hash.h>
> #include "svn_types.h"
>-#include "svn_pools.h"
> #include "svn_string.h"
> #include "svn_config.h"
> #include "svn_private_config.h"
>  
>
This change breaks the build on Windows becahse config_win.c doesn't 
include svn_pools.h, but does use functions declared in that header. It 
may not show up on Unix, but Windows does some name mangling even for C 
that doesn't work right without the declarations.

Please be more careful when making such sweeping changes, and check 
where the declarations are used before removing includes from headers. A 
build isn't enough, you have to grep through the code because of various 
ifdefs.

-- Brane