Re: Qmail-home and qmail-queue configuration (was Re: Next steps for ezmlm-idx)

--MdEjg5WkSuUg8x46
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 15, 2008 at 10:08:46AM +0200, Tullio Andreatta ML wrote:
> Patch attached (sorry, no heavily tested ...)

Thank you.  It all looks like it should work.  I would make the
following suggestions:

1. Put it into a separate file, say config_qmail.c

2. Turn it into two functions (using a common core function) returning a
"const char *", similar to the getflag and flag_isset functions.  Only
copy the result into a stralloc if necessary as there is already a copy
of the auto_qmail string and the environment variable in memory, no need
to make another copy.  Call them getqmailhome and getqmailqueue.

3. Integrate looking up $QMAILHOME and $QMAILQUEUE into these functions.
This will centralize the logic for all three cases into one place.

Since this will become the only use of the auto_qmail variable, it may
make sense to include auto_qmail.c directly instead of just the header
file.

--=20
Bruce Guenter <[email protected]>                http://untroubled.org/

--MdEjg5WkSuUg8x46
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iD8DBQFIzp1P6W+y3GmZgOgRAnzYAJ4gkOy9OcEcwSmVOgM516C7YkPpkgCfaxUD
q8shRt0P/CVPKwCleK7rO4Y=
=WAYC
-----END PGP SIGNATURE-----

--MdEjg5WkSuUg8x46--