[PATCH] Check for SSL methods availability

nandre <[email protected]> Mon, 29 Oct 2018 23:38:28 -0300

Newsgroups	gmane.mail.getmail.user
Message-ID	<[email protected]>

Hi,

It seems support for ssl methods is slowly being droped and is not
built by default on openssl version 1.1.1.

getmail, however, is not checking if these methods are actualy
available on the system before trying to use them if the config file
says so.

getmail.dump (text/plain, 1.4 KB)

  getmail version 5.6
  Python version 2.7.15+ (default, Aug 31 2018, 11:56:52)
[GCC 8.2.0]

Unhandled exception follows:
    File "/usr/local/bin/getmail", line 892, in main
    success = go(configs, options.idle)
    File "/usr/local/bin/getmail", line 157, in go
    retriever.initialize(options)
    File "/usr/local/lib/python2.7/dist-packages/getmailcore/_retrieverbases.py", line 1143, in initialize
    self._connect()
    File "/usr/local/lib/python2.7/dist-packages/getmailcore/_retrieverbases.py", line 337, in _connect
    ssl_version = check_ssl_version(self.conf)
    File "/usr/local/lib/python2.7/dist-packages/getmailcore/utilities.py", line 565, in check_ssl_version
    return ssl.PROTOCOL_SSLv3
  AttributeError: 'module' object has no attribute 'PROTOCOL_SSLv3'

###################################################################

Patch:

--- getmailcore/utilities.py.new        2018-10-29 23:09:45.499754037 -0300
+++ getmailcore/utilities.py.old        2018-10-29 23:08:54.650393300 -0300
@@ -559,9 +559,9 @@
             'Python; requires Python 2.6'
         )
     ssl_version = ssl_version.lower()
-    if ssl_version == 'sslv23' and 'PROTOCOL_SSLv23' in dir(ssl):
+    if ssl_version == 'sslv23':
         return ssl.PROTOCOL_SSLv23
-    elif ssl_version == 'sslv3' and 'PROTOCOL_SSLv3' in dir(ssl):
+    elif ssl_version == 'sslv3':
         return ssl.PROTOCOL_SSLv3
     elif ssl_version == 'tlsv1':
         return ssl.PROTOCOL_TLSv1

signature.asc (application/pgp-signature, 841 B)