Re: [binc] NOOP fails (from time to time)

Peter Stuge wrote:
> On Mon, May 23, 2005 at 03:36:21PM +0200, Jerry Lundström wrote:
> 
>>>..and I guess it should be re-initialized after a CLOSE.
>>
>>Well no, more like operator-close.cc should set the depot selected
>>mailbox to 0 so that any futhur depot.getSelected() returns 0.
> 
> 
> Hm. I'm not sure.
> 
> I think it looks like Depot::defaultmailbox and
> Depot::selectedmailbox indicate the Depot type (ie. IMAPdir or
> Maildir++) rather than the actual folder selected in the mailbox.

No they are Mailbox superclasses with is inherited by IMAPdir or 
Maildir++ . They reside in a array of Mailbox objects and 
defaultmailbox/selectedmailbox are pointers to an element inside that 
array, check depot.get().

This should also be applied additional to my previous patch:

-- 
Jerry Lundström
Sektionen för IT och media, Stockholms universitet
+46 (0)8 16 19 99 / http://www.it.su.se

--- bincimap-1.2.12final.orig/src/operator-select.cc	2005-01-08 11:20:48.000000000 +0100
+++ bincimap-1.2.12final.no_mailbox/src/operator-select.cc	2005-05-23 16:01:43.000000000 +0200
@@ -90,6 +90,7 @@
   Mailbox *mailbox = depot.getSelected();
   if (mailbox != 0) {
     mailbox->closeMailbox();
+    depot.resetSelected();
     mailbox = 0;
   }