Re: imap/lmtp_sieve.c missing include acl.h?
"ellie timoney" <[email protected]> Fri, 17 Jul 2026 11:46:28 +1000
| Newsgroups | gmane.mail.imap.cyrus |
|---|---|
| Message-ID | <[email protected]> |
--a6768fb5b90bd512870931267e02fb779833f306 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 15 Jul 2026, at 7:29 PM, [email protected] wrote: > Added #include "acl.h" to lmtp_sieve.c and compiles correctly Yeah, that seems fine. On a larger scale, the problem is that the append API requires callers to u= se constants from acl.h. lmtp_sieve.c is correctly including append.h, but= append.h alone isn't enough. My fix makes it so append.h is enough: https= ://github.com/cyrusimap/cyrus-imapd/pull/6142 Cheers, ellie ------------------------------------------ Cyrus: Info Permalink: https://cyrus.topicbox.com/groups/info/Ta23e8d2dc952dbc6-M840069= 0799fb3204c7131da3 Delivery options: https://cyrus.topicbox.com/groups/info/subscription --a6768fb5b90bd512870931267e02fb779833f306 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html><html><html><head><title></title></head><body><div>On Wed, 15 Jul 202= 6, at 7:29 PM, <a href=3D"mailto:[email protected]">cyrus@jameslaw.= co.uk</a> wrote:</div><blockquote id=3D"qt" style=3D"" type=3D"cite"><div>A= dded #include "acl.h" to lmtp_sieve.c and compiles correctly</div= ></blockquote><div><br /></div><div>Yeah, that seems fine.<br /></div><div>= <br /></div><div>On a larger scale, the problem is that the append API requ= ires callers to use constants from acl.h. lmtp_sieve.c is correctly i= ncluding append.h, but append.h alone isn't enough. My fix makes = it so append.h is enough: <a href=3D"https://github.com/cyrusimap/cyrus-ima= pd/pull/6142">https://github.com/cyrusimap/cyrus-imapd/pull/6142</a><br /><= /div><div><br /></div><div>Cheers,</div><div><br /></div><div>ellie</div><d= iv id=3D"topicbox-footer" style=3D"margin:10px 0 0;border-top:1px solid #dd= d;border-color:rgba(0,0,0,.15);padding:7px 0;"> <strong><a href=3D"https://cyrus.topicbox.com/latest" style=3D"color:inheri= t;text-decoration:none">Cyrus</a></strong> / Info / see <a href=3D"https://cyrus.topicbox.com/groups/info">discussions</a> + <a href=3D"https://cyrus.topicbox.com/groups/info/members">participants</a> + <a href=3D"https://cyrus.topicbox.com/groups/info/subscription">delivery&nb= sp;options</a> <a href=3D"https://cyrus.topicbox.com/groups/info/Ta23e8d2dc952dbc6-M840069= 0799fb3204c7131da3" style=3D"float:right">Permalink</a> </div> </body></html></html></html>= --a6768fb5b90bd512870931267e02fb779833f306--