Re: Mimetype discreate typo APPLICATION should be AUDIO

"DINH Viêt Hoà" <[email protected]> Thu, 11 Oct 2007 19:47:05 +0200
Newsgroups gmane.mail.libetpan.user
Message-ID <[email protected]>
On 10/11/07, Simon Banks <[email protected]> wrote:
> I've was wondering why audio mime types have been reported as
> application/<type> for a while so looking at the libetpan method in
> src/driver/implementation/imap/imapdriver_tools.c
> static int imap_body_media_basic_to_content_type()
>
> Is see the switch/case
>
>  case MAILIMAP_MEDIA_BASIC_AUDIO:
>     mime_type_type = MAILMIME_TYPE_DISCRETE_TYPE;
>     discrete_type_type = MAILMIME_DISCRETE_TYPE_APPLICATION;
>     break;
>
> Should be
>
>  case MAILIMAP_MEDIA_BASIC_AUDIO:
>     mime_type_type = MAILMIME_TYPE_DISCRETE_TYPE;
>     discrete_type_type = MAILMIME_DISCRETE_TYPE_AUDIO;
>     break;
>
> I've made the code change for my current release using libetpan0.52 and
> include a diff file for your convenience.
>
> Regards
> Simon
>
> --
> Knowledge is a process of piling up facts; wisdom lies in their simplification.
>
>
> 396c396
> <     discrete_type_type = MAILMIME_DISCRETE_TYPE_AUDIO;
> ---
> >     discrete_type_type = MAILMIME_DISCRETE_TYPE_APPLICATION;

Hello, the fix has been committed.

Thanks.

-- 
DINH Viêt Hoà

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/