Crash when editing preferences twice
Xavier Nodet <[email protected]>
| Newsgroups | gmane.mail.mahogany.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi all, Try the following: - Open M - Hit Shift-Ctrl-E - Hit Return - Hit Shift-Ctrl-E again, see the nice crash... The attached patch seemingly corrects this problem. -- Xavier Nodet "They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." - Benjamin Franklin, 1759.
MissingIncRef.patch
(application/octet-stream, 625 B)
cvs -z3 diff -u -wb -- src\gui\wxDialogLayout.cpp (in directory U:\src\M\)
Index: src/gui/wxDialogLayout.cpp
===================================================================
RCS file: /cvsroot/mahogany/M/src/gui/wxDialogLayout.cpp,v
retrieving revision 1.118
diff -u -w -b -r1.118 wxDialogLayout.cpp
--- src/gui/wxDialogLayout.cpp 11 Jul 2005 22:43:01 -0000 1.118
+++ src/gui/wxDialogLayout.cpp 19 Jul 2005 09:49:28 -0000
@@ -1398,6 +1398,7 @@
m_profileForButtons = GetProfile();
if ( m_profileForButtons )
{
+ m_profileForButtons->IncRef();
m_profileForButtons->Suspend();
}
signature.asc
(application/pgp-signature, 205 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (MingW32) - GPGrelay v0.959 iD8DBQBC3NbFFK6OUIeqvjQRAtkiAJwOdQNFaQYalF1u2jt5WDfnY4+geQCfUrT2 weZEdLZTx5Lgx+TMbIdN8Qc= =x7jx -----END PGP SIGNATURE-----