Re: Timestamp on Sent Messages

On Wed, 20 Jul 2005 12:36:59 +0200 Vadim Zeitlin <[email protected]> wrote:

> On Tue, 19 Jul 2005 14:11:15 +0200 Xavier Nodet <[email protected]> wrote:
>
> XN> On Mon, 1 Dec 2003 23:04:02 +0100 (Romance Standard Time) Vadim Zeitlin <[email protected]> wrote:
> XN> 
> XN> > On Mon, 1 Dec 2003 03:03:03 -0800 (PST) Michael A Chase <[email protected]> wrote:
> XN> 
> XN> > MAC> I recently sent an email that had been sitting in the Drafts folder for
> XN> > MAC> a week.  The timestamp reflected when I first saved the message, not
> XN> > MAC> when I sent it.
> XN> >
> XN> >  This is a bug.
> XN> 
> XN> The attached patch corrects it.
>
>  I admit to not quite understanding how it works 
>  [...]
>  I'd rather think that the date header should be only added if !forStorage
> but I must be missing something?

There is at least one case (when using 'save as draft') where my
intuition says that forStorage should be true but this is not the case.

  Md.exe!SendMessageCC::Build(bool forStorage=false)  Line 1318	C++
 	Md.exe!SendMessageCC::WriteMessage(long (void *, char *)* writer=0x009818d0, void * where=0x01b6f32c)  Line 2069	C++
 	Md.exe!SendMessageCC::WriteToString(wxString & output={...})  Line 2080 + 0x11	C++
 	Md.exe!SendMessageCC::WriteToFolder(const wxString & name={...})  Line 2144 + 0x11	C++
 	Md.exe!wxComposeView::SaveAsDraft()  Line 4826 + 0x25	C++
 	Md.exe!wxComposeView::OnMenuCommand(int id=235)  Line 3185 + 0x8	C++
 	Md.exe!wxMFrame::OnCommandEvent(wxCommandEvent & event={...})  Line 1057 + 0x19	C++
 	Md.exe!wxEvtHandler::ProcessEventIfMatches(const wxEventTableEntryBase & entry={...}, wxEvtHandler * handler=0x01fffce0, wxEvent & event={...})  Line 1191 + 0xf	C++
 	Md.exe!wxEventHashTable::HandleEvent(wxEvent & event={...}, wxEvtHandler * self=0x01fffce0)  Line 868 + 0x1c	C++
 	Md.exe!wxEvtHandler::ProcessEvent(wxEvent & event={...})  Line 1247 + 0x23	C++
 	Md.exe!wxFrameBase::ProcessCommand(int id=235)  Line 220 + 0x1c	C++
 	Md.exe!wxFrame::HandleCommand(unsigned short id=235, unsigned short cmd=0, void * control=0x00000000)  Line 894 + 0xd	C++
 	Md.exe!wxFrame::MSWWindowProc(unsigned int message=273, unsigned int wParam=235, long lParam=0)  Line 1005 + 0x16	C++
 	Md.exe!wxWndProc(HWND__ * hWnd=0x0006112c, unsigned int message=273, unsigned int wParam=235, long lParam=0)  Line 2265 + 0x1c	C++

Basically, my goal was to
- set a Date header when saving as draft, so that the user can keep
  track of the messages in the Draft folder,
- but reset the Date header to current date/time when actually sending.

> but if it fixes the problem, do check it in please...

Done.

-- 
Xavier Nodet
"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety." - Benjamin Franklin, 1759.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32) - GPGrelay v0.959

iD8DBQBC3kiGFK6OUIeqvjQRAgddAJ4l9KuP/IsBSxUWqQc8Vsp5A554egCfR880
RT+TiWC/uCchQt5y2lV5ONU=
=5eRr
-----END PGP SIGNATURE-----