maildrop: if failing to deliver, give back temporary failure.

Hi,

The attached patch is a Debian patch on the issue reported as:
   http://bugs.debian.org/265399 (Y2004)

This makes maildrop compiled for independent use (i.e., not for courier)
to return the same error code as the maildrop for courier.

This patch has been in use for Debian from Aug 2004 17:22:00 +0200

(maildrop in 2004 seems to have changed HAVE_COURIER behavior from throw
77 to throw 75 with V0.70)

Basically Debian package always through 75 even if maildrop is compiled for
non-courier use by patching out "#else" part of the following code section.

               if ( deliver_maildir.MaildirOpen(mailbox, deliver_file,
                       maildrop.msgptr->MessageSize()) < 0)
               {
#if HAVE_COURIER
                       throw 75;
#else
                       throw 77;
#endif
               }

We know there are complication of doing this but addressing such corner
case was not the choice of the upstream as I understand.  So Debian is
using the attached simple patch still now while suggesting workaround
indicated by the upstream for the corner case user.  It's history is at:

   http://bugs.debian.org/481223 (2008)

Considering this history, it may be good idea to merge this patch to the
upstream source minimize differences between independent and courier
binaries (i.e., less HAVE_COURIER).

Regards,

Osamu

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Courier-maildrop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/courier-maildrop

Author: Andreas Barth <[email protected]>
Description: maildrop (1.5.3-1.1) unstable; urgency=low

  * NMU during Darmstadt BSP
  * if failing to deliver, give back temporary failure. Closes: #265399

 -- Andreas Barth <[email protected]>  Sat, 21 Aug 2004 17:22:00 +0200

 http://bugs.debian.org/265399
 http://bugs.debian.org/481223

--- maildrop.orig/libs/maildrop/deliver.C
+++ maildrop/libs/maildrop/deliver.C
@@ -162,11 +162,7 @@ Buffer	b;
 		if ( deliver_maildir.MaildirOpen(mailbox, deliver_file,
 			maildrop.msgptr->MessageSize()) < 0)
 		{
-#if HAVE_COURIER
 			throw 75;
-#else
-			throw 77;
-#endif
 		}
 
 		format_mbox.Init(0);