Re: Question about Sender

Michael Yount <[email protected]> Sat, 13 Oct 2007 17:35:27 -0700
Newsgroups gmane.mail.majordomo.majordomo2.devel
Message-ID <[email protected]>
John L wrote:
>>> Or, is there some way to cause the Sender header to have the 
>>> listname if it's a message from the list?
>>>
>> The help document for the "sender" setting explains why this is a bad 
>> idea (it would disable bounce handling.)
>
> I'm confused. The "sender" setting says it sets the SMTP bounce 
> address. But we're talking about the Sender: header in the message 
> itself. I gather the code sets both.
Yes, Mj2 adds a "Sender" header to each posted message.
>
> There's no reason that the two have to be the same, and one can make a 
> reasonable case that the correct thing to put in the Sender: header 
> from the point of view of RFC compliance is the list address.
Other people have argued for using the list owner's address, or for 
using Resent-Sender for that purpose instead. RFC 2822 seems ambiguous. 
Is there a more recent document that clarifies this issue?
>
> Would anything break if we simply commented out a few lines of code so 
> it doesn't add a Sender: header. You can put Sender: in 
> message_headers now, but then you get two headers which is definitely 
> wrong.
>
That's the question. Here's a patch for anyone who want to try.

Michael

--- lib/Mj/Resend.pm 12 Jul 2005 01:05:35 -0000 1.211
+++ lib/Mj/Resend.pm 14 Oct 2007 00:33:56 -0000
@@ -727,9 +727,9 @@
$head->add('Precedence', $precedence);
}

- if ($sender) {
- $head->add('Sender', $sender);
- }
+ # if ($sender) {
+ # $head->add('Sender', $sender);
+ # }

$subs->{'USER'} = $head->get('From');